Skip to content

fix(ios): open Device Hub when Simulator.app is unavailable #405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aihdene-genetec wants to merge 1 commit into from
Closed

fix(ios): open Device Hub when Simulator.app is unavailable #405

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 29 additions & 6 deletions src/ios/utils/simulator.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import { pathExists } from '@ionic/utils-fs';
import { spawnSync } from 'child_process'; // TODO: need cross-spawn for windows?
import * as Debug from 'debug';

Expand All @@ -9,6 +10,12 @@ import { getXCodePath } from './xcode';

const debug = Debug('native-run:ios:utils:simulator');

/**
* Xcode 27 removed Simulator.app and replaced it with Device Hub, which lives
* outside the developer directory and so can only be located by bundle id.
*/
const DEVICE_HUB_BUNDLE_ID = 'com.apple.dt.Devices';

export interface Simulator {
availability: '(available)' | '(unavailable)';
isAvailable: boolean;
Expand Down Expand Up @@ -67,6 +74,25 @@ export async function getSimulators(): Promise<SimulatorResult[]> {
}
}

/**
* Returns the `open` arguments used to bring up the simulator UI.
*
* Prefers Simulator.app when it is present so behavior is unchanged on Xcode 26
* and earlier, and falls back to opening Device Hub by bundle id on Xcode 27+,
* where Simulator.app no longer exists.
*/
async function getSimulatorOpenArgs(): Promise<string[]> {
const xCodePath = await getXCodePath();
const simulatorAppPath = `${xCodePath}/Applications/Simulator.app`;

if (await pathExists(simulatorAppPath)) {
return [simulatorAppPath];
}

debug(`Simulator.app not found at ${simulatorAppPath}, falling back to Device Hub`);
return ['-b', DEVICE_HUB_BUNDLE_ID];
}

export async function runOnSimulator(udid: string, appPath: string, bundleId: string, waitForApp: boolean) {
debug(`Booting simulator ${udid}`);
const bootResult = spawnSync('xcrun', ['simctl', 'boot', udid], {
Expand All @@ -83,13 +109,10 @@ export async function runOnSimulator(udid: string, appPath: string, bundleId: st
throw new Exception(`There was an error installing app on simulator: ${installResult.stderr}`);
}

const xCodePath = await getXCodePath();
debug(`Running simulator ${udid}`);
const openResult = spawnSync(
'open',
[`${xCodePath}/Applications/Simulator.app`, '--args', '-CurrentDeviceUDID', udid],
{ encoding: 'utf8' },
);
const openResult = spawnSync('open', [...(await getSimulatorOpenArgs()), '--args', '-CurrentDeviceUDID', udid], {
encoding: 'utf8',
});
if (openResult.status) {
throw new Exception(`There was an error opening simulator: ${openResult.stderr}`);
}
Expand Down