Conversation
Use NATIVE_RUN_ADB_TIMEOUT env variable for all standard ADB operations while retaining ADB_TIMEOUT as a legacy fallback, and document the setting in Android CLI help. This prevents ADB timeout errors on setups with high latency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added NATIVE_RUN_ADB_TIMEOUT env variable for all standard ADB operations while retaining ADB_TIMEOUT as a legacy fallback, and documented the setting in Android CLI help.
Change Type
Rationale / Problems Fixed
This fixes #259
My particular problem was when using devices from remote test labs like SmartDust
I was getting enigmatic errors in Ionic Capacitor caused by too short ADB timeouts, resulting from high latency in my remote setup. The error originated from this tool - the default ADB timeout was rigid and too short for some cases.
Tests or Reproductions
Added appropriate unit tests.
Also tested on real Android devices connected remotely when using Ionic Capacitor. After my fix, Ionic Capacitor was able to work with my Android devices.
Platforms Affected