Conversation
GNU tar --strip-components does not chown, chmod, or utimes the destination when a directory entry strips to an empty path. Skip those directory entries so extracting as root cannot change cwd.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
stripleaves a directory (or GNU dumpdir) with an empty path, unpack currently still applies that entry's owner/mode/mtime to the extraction directory. GNU tar--strip-componentsdoes not do that, and as root this can changecwdpermissions and ownership (#294).This skips those leftover directory entries after stripping, matching GNU tar. Nested files such as
dir/keep.txtstill extract askeep.txt.Test plan
npx tap test/unpack.js --disable-coverage --grep 'strip does not chown the extraction directory'fails without the CHECKPATH skip and passes with it (async + sync)using strip option when top level file existsstill passesFixes #294