Repository navigation
Conversation
Unsupported entries (sockets, FIFOs, devices) end WriteEntry with no header as soon as they are constructed. When that happens for a read-ahead job, shifting the queue head drops the file being packed and stalls create(). Remove the completed job specifically instead. Fixes isaacs#295
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
JOBDONEalwaysshift()ed the pack queue head. Unsupported entry types (sockets, FIFOs, devices) finishWriteEntrywith no header as soon as they are constructed, which can happen while they are still read-ahead jobs.JOBSnever drains, andcreate()never settles (#295).Test plan
test/pack.jsmocks delayedlstatfor the file and synchronous socket-like stats for two later entries so the hang is deterministicmain(Pack hung on unsupported read-ahead entries) and passes with this changetest/pack.jsrun: only pre-existing zstd unsupported failures remainFixes #295