fix(status): preserve Patrol Fix progress across restarts - #1214
Open
ivankuznetsov wants to merge 2 commits into
Open
fix(status): preserve Patrol Fix progress across restarts#1214ivankuznetsov wants to merge 2 commits into
ivankuznetsov wants to merge 2 commits into
Conversation
Owner
Author
|
hive-babysitter could not repair this PR automatically. Outcome: failure Agent tail: |
ivankuznetsov
force-pushed
the
fix/patrol-stale-lock-status
branch
from
August 26, 2026 05:17
4dbf205 to
2b623a2
Compare
ivankuznetsov
force-pushed
the
fix/patrol-stale-lock-status
branch
from
August 26, 2026 14:28
2b623a2 to
63d7106
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
After a daemon restart, operational status no longer turns a receipt-progressed Patrol Fix task into
needs_repaironly because a completed predecessor attempt left a dead PID in.lock. Durable workflow progress stays scheduler-owned, and the next dispatch reclaims the stale lock automatically. Currentagent_running,AGENT_WORKING, andREVIEW_WORKINGclaims with a dead recorded runner still report repair.Validation
bundle exec ruby -Ilib -Itest test/unit/operational_status_test.rb(59 runs, 275 assertions)bundle exec ruby -Ilib -Itest test/unit/commands/status_operational_test.rb(6 runs, 18 assertions)bundle exec ruby -Ilib -Itest test/unit/schema_files_test.rb(161 runs, 910 assertions)bundle exec ruby -Ilib -Itest test/unit/lock_test.rb --name test_stale_lock_with_dead_pid_is_replaced(1 run, 1 assertion)git diff --checkbundle exec rubocopcould not start because the host mise configuration has no Ruby version selected for therubocopshim. Hosted CI remains the lint gate.