Repository navigation
feat(f14): recommendation lifecycle registry and event emitter - #6
Merged
Merged
Conversation
CAS-based state machine (created->grounding_checked->shown->issued|expired, failed from either blocked stage) with thread-safe transitions and idempotent delivery confirmation. Covers two of the three components agreed in the WP-521 peer session (Claude+Kimi+Codex, 2026-10-17); candidate_builder is deferred pending a field-provenance audit against planner.py/source_finder.py. Refs: peer-session 2026-10-17-08-f14-adapter-raw Review iters: 2 Verify: PASS (21/21 new tests, 214/214 full suite) Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
candidate_builderis deferred pending a field-provenance audit against planner.py/source_finder.py.mainbypassed required-PR/status-check protection unexpectedly and was reverted (commit 1a7a9f5) -- this PR resubmits the identical content through the normal review path.Test plan
pytest generator/test_recommendation_registry.py -v-- 21/21 passed, including two real multi-threaded concurrency tests (confirm-vs-confirm, confirm-vs-expire races)pytest generator/(full suite) -- 214/214 passed, no regressions:memory:default) fixed and re-verified🤖 Generated with Claude Code