Repository navigation
feat(f14): candidate_builder for Path A (club posts, WP-521) - #7
Open
TserenTserenov wants to merge 1 commit into
Open
TserenTserenov wants to merge 1 commit into
TserenTserenov wants to merge 1 commit into
Conversation
Assembles a raw-v0 RawV0Candidate from a participant's own club post (connect_source, WP-545). New selection_basis value "connected_source" distinguishes this origin from the pedagogical bottleneck|qualification pair. topic_ref stays None pending a classifier (open item, not blocking). Consensus: WP-521 peer session (Claude + Kimi + Codex), 2026-10-22. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
generator/candidate_builder.py::build_club_post_candidate— assembles aRawV0Candidate(raw-v0 contract) from a participant's own club post (connect_source, WP-545).selection_basisvalue"connected_source", distinct from the pedagogicalbottleneck/qualificationpair: the candidacy here traces to the connect_source mechanism, not a system-made pedagogical choice.topic_refstaysNonepending a classifier (open item, not blocking this path).recommendation_registry.py's own docstring explicitly scoped this builder out, citing a different blocker (no provenance from the bottleneck/qualification selection code,planner.py/source_finder.py) — that blocker is specific to the other input path (programmatic bottleneck-driven selection), not to club posts, which never go through that code at all.Consensus: WP-521 peer session (Claude + Kimi + Codex), 2026-10-22 — rationale for naming and decision recorded inline in the module docstring (following
recommendation_registry.py's own precedent of documenting peer-session consensus there, rather than a separate ADR).Test plan
pytest generator/test_candidate_builder.py generator/test_recommendation_registry.py— 23 passed (2 new + 21 existing, no regressions)ruff checkon both new files — clean