Conversation
- Added creating custom error pages for groups - Added route prefix for error function - `class@method` is now available in error function You can browse the test folder for usage examples of the added features. => https://github.com/venloress/php-router/tree/venlo/tests
- Added creating custom error pages for groups - Added route prefix for error function - `class@method` is now available in error function Thanks for your time
According to my last edits. Fixed an issue where I couldn't reach the default error page
Author
|
i tested it again with the last edits and it doesn't seem to be a problem. i've an idea to create custom pages based on error codes. i'll work on it. idea; $router->error('home@notfound',['errorCode' => 403]); |
Owner
|
Hi @Venloress . Thank you for your effort. I will test your changes in locally and after that we can merge it with main branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tried my best to do. I would be very happy if I could contribute.
I did the question I asked today and a little more.
I added the following features;
Error pages created in groups are now specific to that group
'home@notfound' is now available in error function
route prefix can be set in error function regardless of group
That's all,
maybe it could have been better. That's as much as I can. I really need this feature