Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
end_turndo not keep a turn open. Late daemon metadata cannot certify a Result.Verification
Submitted revision:
261d4ac31. Focused fixtures passed with 93 ACP adapter tests and 34 Antigravity integration tests. The integration fixture verified persisted reactive text after interruption and an unpublished Result.npm run checkexited 0 with 445 contract tests. GitHub CI was still running at the last observation.A prior live
agy 1.5.14trace on Linux received unsolicited tool and text updates after the first prompt response, but no explicit reactive end event. The conservative timeout policy was verified with fixtures. The request for a documented completion signal is upstream.Limitation
ACP can make a synchronous steered command and an async command whose continuation has not yet announced itself look identical once their tool status and steering response have both settled. The fallback protects observed reactive work and does not establish a guarantee for that ordering.
Review
The conservative revision removes the quiet-interval publication path flagged by the previous review. Loop review
61a828fb-2bf9-485a-89cf-6294caf94e31completed with all three reviewers responding. Merge remains blocked. The review identified ambiguous ownership for a tool across two steers and an approval that precedes its steer echo. The observed reactive-wait fallback is implemented, but these overlapping cases lack an authoritative association between ACP updates and their originating prompt or continuation.