Repository navigation
v0.3.0 2/3: Mobile-first Feed polish, one-tap Done closure, and composer agent pills - #414
Merged
Merged
Conversation
… label reply archive accurately, keep pills visible with keyboard open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mobile-first Feed redesign, scoped strictly to mobile-first UX (desktop split-pane/sidebar unchanged).
Summary of changes
Done/Archiveclosure (src/client/Feed.tsx,src/client/design.css):onDismiss/PATCH /api/feed/:idpath, unread badge decrement, and toast withUndo) as well as in the Feed reading sheet footer.<Archive /> Archive(matchingreplyStatearchival and"Reply archived.") and Done cards with<Check /> Done(matching"Removed from Done.").Needs youfailure cards (dismissLabel === "Dismiss from Needs you") and grouped threads so decisions stay explicit.dismissFeedCardand itsUndocallback with a per-owner/per-card in-flight lock (dismissingRef+dismissingCardsstate) and disables the quick-dismiss button while pending so repeated clicks cannot issue duplicatePATCHrequests that race withUndo.src/client/design.css,@media (max-width: 650px)):48pxleft gutter on mobile Feed card content and action rows so headlines, markdown previews, and charts span the full phone width..card-actionsas44px-tall touch-friendly pills with warm-brass.next-actionand sage-green.card-action-done.WorkingandNeeds youmobile agent portraits and soft warm-brass elevation on.needs-stack.src/client/app/Composer.tsx,src/client/design.css):Quick recipientpill strip (withAutowhen routing is enabled and22pxgeometric animal avatars for each available agent) synced with the existing<select aria-label="Agent recipient">.replyContext,contextArtifact, andfolderChoiceare preserved; switching to a different recipient clears them as before.32pxheight) whenhtml[data-keyboard="open"]so phones can still one-tap switch recipients whenlaunchComposer()focuses the textarea, while keeping the composer body and footer unobstructed on390×362and320×362keyboard viewports.scripts/helpers/workspace-project-smoke.mjsto exercise one-tapDonedismissal (both on the Feed card and inside the reading sheet), rapid repeatedDonetaps while the firstPATCHis held in flight (asserting disabled state, singlePATCH, and cleanUndorestoration), andPATCH /api/feed/*503failure handling from the reading sheet.scripts/helpers/profile-photos-recipient-smoke.mjsto exercise tapping aQuick recipientpill, verifying same-recipient tap preservesreplyContext(.composer-reply-chip), and switching recipient clearsreplyContextwhile syncing<select>andaria-pressed="true".scripts/helpers/main-composer-keyboard-smoke.mjsto verify theQuick recipientgroup remains visible in viewport withdata-keyboard="open"at both390×362and320×362.Review fixes
Round 1 (
a817429b-09b5-4a79-bc29-1c8d7564fad2, commit468c4c868):replyContext/contextArtifact/folderChoicewhen tapping the already-selected recipient pill (selectRecipientno-op guard + regression).Archivewith<Archive />icon instead ofDone.Quick recipientpills visible in compact form whendata-keyboard="open"(+390×362and320×362regressions).Donedismissal503failure regression inworkspace-project-smoke.mjs.Round 2 (
8e3f3622-08f0-4f08-a279-da272f404441, commita7e9ba87e):dismissingRef/dismissingCards) fordismissFeedCardandUndo, disabling quick-dismiss buttons while pending so duplicate taps cannot raceUndo, plus regression inworkspace-project-smoke.mjs.Round 3 (
7825388e-86d4-42c2-aaa4-41cefed1702b, commita7e9ba87e): The reviewers found that a forced click on the disabled quick action never entered the dismissal handler. The follow-up waits for the first hide PATCH to reach the interceptor, then invokes the enabled Thread actions → Remove from Done command while the request is held. The smoke checks that only one hide PATCH was sent and Undo restores the card.Round 4 (
514ed578-1d69-499b-ac7c-df42e8cbef21, commit7e340da99): All three reviewers completed. The consolidated static review reported no confirmed introduced bugs. It flagged a possible dismissal race across Feed remounts without establishing that the PR introduced it.Canonical example followed: none (client mobile layout, Feed card action, and composer recipient control refinement; no new server routes, SQL tables, or external effects).
Verification
Submitted commit:
7e340da998532bebf205a1ed0c069ca853666e16npm run checkassets,format,typecheck,openapi,sql-index, andcontractspassed (38 files, 445 tests).npm run buildLOOP_BROWSER=chromium node scripts/design-browser-smoke.mjs workspace-projectEarlier verification at
a7e9ba87e15d2037a5c1e36066120573011e09e7follows. The new commit changed only the workspace-project smoke. The prior quick-dismiss double-tap fixture did not reach the handler while the button was disabled.npm run checkassets,format,typecheck,openapi,sql-index, andcontracts38/38 test files, 445/445 tests passed)npm run builddist/webbuilt in 1.81s)npx vitest run test/feed-done-refresh.test.ts test/feed-projection-client.test.ts test/your-agents.test.tsx --maxWorkers=1npx vitest run test/composer-context.test.ts test/composer-launch.test.ts test/done-thread-client.test.ts test/feed-read-recovery.test.ts test/result-actions.test.tsx --maxWorkers=1LOOP_BROWSER=chromium node scripts/heavy-command.mjs scripts/design-scenario.mjs workspace-projectDonesingle-PATCH guard +Undo+ reading-sheet503failure retention + reading-sheetDone+Undo)LOOP_BROWSER=chromium node scripts/heavy-command.mjs scripts/design-scenario.mjs profile-photos-recipientQuick recipientsame-tap context preservation, recipient switch context clear, and<select>sync)LOOP_BROWSER=chromium node scripts/heavy-command.mjs scripts/design-scenario.mjs main-composer-keyboard390×362&320×362open-keyboard layout withQuick recipientpills visible)LOOP_BROWSER=chromium node scripts/heavy-command.mjs scripts/design-scenario.mjs needs-stackLOOP_BROWSER=chromium node scripts/heavy-command.mjs scripts/design-scenario.mjs mobile-nav-viewport390&320mobile nav + composer dock alignment)LOOP_BROWSER=chromium node scripts/heavy-command.mjs scripts/design-scenario.mjs visual-layout320–1920widths, light & dark themes, zero horizontal overflow)LOOP_BROWSER=chromium node scripts/heavy-command.mjs scripts/feed-transfer-smoke.mjsinitialAvatars: 8, afterScrollAvatars: 13, reloadCodeBytes: 0)Loop checks/check,tests (1),tests (2),tests (3))a7e9ba87e15d2037a5c1e36066120573011e09e7Limitations & notes
scripts/helpers/design-fixture.mjsdoes not callpublishCompletedRunResult()on its default seeded runs, so older design scenarios that expect sealedDonepreviews without publishing them (done-card-dismissal,feed-reading,feed-reply-keyboard) fail onmainindependently of this PR. One-tapDone, rapid double-tap guard, and dismissal-failure coverage were added toworkspace-project-smoke.mjs, which publishes a real sealed Result viapublishCompletedRunResult().