Skip to content

v0.3.0 2/3: Mobile-first Feed polish, one-tap Done closure, and composer agent pills - #414

Merged
j-asefa merged 4 commits into
mainfrom
feat/mobile-feed-redesign
Nov 21, 2026
Merged

j-asefa merged 4 commits into
mainfrom
feat/mobile-feed-redesign

Conversation

@j-asefa

@j-asefa j-asefa commented Nov 21, 2026 •

Copy link
Copy Markdown
Owner

Mobile-first Feed redesign, scoped strictly to mobile-first UX (desktop split-pane/sidebar unchanged).

Summary of changes

  • One-tap Done / Archive closure (src/client/Feed.tsx, src/client/design.css):
    • Added an explicit one-tap quick-dismiss button on dismissible Done and Replies feed cards (reusing the existing onDismiss / PATCH /api/feed/:id path, unread badge decrement, and toast with Undo) as well as in the Feed reading sheet footer.
    • Labels Reply cards with <Archive /> Archive (matching replyState archival and "Reply archived.") and Done cards with <Check /> Done (matching "Removed from Done.").
    • Excludes Needs you failure cards (dismissLabel === "Dismiss from Needs you") and grouped threads so decisions stay explicit.
    • Guards dismissFeedCard and its Undo callback with a per-owner/per-card in-flight lock (dismissingRef + dismissingCards state) and disables the quick-dismiss button while pending so repeated clicks cannot issue duplicate PATCH requests that race with Undo.
  • Full-bleed mobile Feed cards & visual rhythm (src/client/design.css, @media (max-width: 650px)):
    • Removed the 48px left gutter on mobile Feed card content and action rows so headlines, markdown previews, and charts span the full phone width.
    • Styled mobile .card-actions as 44px-tall touch-friendly pills with warm-brass .next-action and sage-green .card-action-done.
    • Added subtle status rings around Working and Needs you mobile agent portraits and soft warm-brass elevation on .needs-stack.
  • One-tap mobile composer recipient pills (src/client/app/Composer.tsx, src/client/design.css):
    • Added a horizontally scrollable Quick recipient pill strip (with Auto when routing is enabled and 22px geometric animal avatars for each available agent) synced with the existing <select aria-label="Agent recipient">.
    • Selecting the already-active recipient pill is a no-op so replyContext, contextArtifact, and folderChoice are preserved; switching to a different recipient clears them as before.
    • Stays visible (compact 32px height) when html[data-keyboard="open"] so phones can still one-tap switch recipients when launchComposer() focuses the textarea, while keeping the composer body and footer unobstructed on 390×362 and 320×362 keyboard viewports.
  • Regression coverage:
    • Extended scripts/helpers/workspace-project-smoke.mjs to exercise one-tap Done dismissal (both on the Feed card and inside the reading sheet), rapid repeated Done taps while the first PATCH is held in flight (asserting disabled state, single PATCH, and clean Undo restoration), and PATCH /api/feed/* 503 failure handling from the reading sheet.
    • Extended scripts/helpers/profile-photos-recipient-smoke.mjs to exercise tapping a Quick recipient pill, verifying same-recipient tap preserves replyContext (.composer-reply-chip), and switching recipient clears replyContext while syncing <select> and aria-pressed="true".
    • Extended scripts/helpers/main-composer-keyboard-smoke.mjs to verify the Quick recipient group remains visible in viewport with data-keyboard="open" at both 390×362 and 320×362.

Review fixes

  • Round 1 (a817429b-09b5-4a79-bc29-1c8d7564fad2, commit 468c4c868):

    • Preserved composer replyContext/contextArtifact/folderChoice when tapping the already-selected recipient pill (selectRecipient no-op guard + regression).
    • Distinguished Reply card quick-dismiss as Archive with <Archive /> icon instead of Done.
    • Kept Quick recipient pills visible in compact form when data-keyboard="open" (+ 390×362 and 320×362 regressions).
    • Added reading-sheet Done dismissal 503 failure regression in workspace-project-smoke.mjs.
  • Round 2 (8e3f3622-08f0-4f08-a279-da272f404441, commit a7e9ba87e):

    • Added synchronous ref + React state in-flight guard (dismissingRef / dismissingCards) for dismissFeedCard and Undo, disabling quick-dismiss buttons while pending so duplicate taps cannot race Undo, plus regression in workspace-project-smoke.mjs.
  • Round 3 (7825388e-86d4-42c2-aaa4-41cefed1702b, commit a7e9ba87e): The reviewers found that a forced click on the disabled quick action never entered the dismissal handler. The follow-up waits for the first hide PATCH to reach the interceptor, then invokes the enabled Thread actions → Remove from Done command while the request is held. The smoke checks that only one hide PATCH was sent and Undo restores the card.

  • Round 4 (514ed578-1d69-499b-ac7c-df42e8cbef21, commit 7e340da99): All three reviewers completed. The consolidated static review reported no confirmed introduced bugs. It flagged a possible dismissal race across Feed remounts without establishing that the PR introduced it.

Canonical example followed: none (client mobile layout, Feed card action, and composer recipient control refinement; no new server routes, SQL tables, or external effects).

Verification

Submitted commit: 7e340da998532bebf205a1ed0c069ca853666e16

Command Observed result on the submitted tree
npm run check Exited 0. assets, format, typecheck, openapi, sql-index, and contracts passed (38 files, 445 tests).
npm run build Exited 0.
LOOP_BROWSER=chromium node scripts/design-browser-smoke.mjs workspace-project Exited 0. The local fixture exercised a pending quick dismissal, the enabled menu action, single-PATCH enforcement, Undo, and reading-sheet dismissal failure.
GitHub Actions All four checks passed on the submitted head, including the three full-suite shards. The full Vitest suite was delegated to CI for this revision.

Earlier verification at a7e9ba87e15d2037a5c1e36066120573011e09e7 follows. The new commit changed only the workspace-project smoke. The prior quick-dismiss double-tap fixture did not reach the handler while the button was disabled.

Command Result
npm run check Exited 0 (assets, format, typecheck, openapi, sql-index, and contracts 38/38 test files, 445/445 tests passed)
npm run build Exited 0 (dist/web built in 1.81s)
npx vitest run test/feed-done-refresh.test.ts test/feed-projection-client.test.ts test/your-agents.test.tsx --maxWorkers=1 Exited 0 (3/3 files, 16/16 tests passed)
npx vitest run test/composer-context.test.ts test/composer-launch.test.ts test/done-thread-client.test.ts test/feed-read-recovery.test.ts test/result-actions.test.tsx --maxWorkers=1 Exited 0 (5/5 files, 25/25 tests passed)
LOOP_BROWSER=chromium node scripts/heavy-command.mjs scripts/design-scenario.mjs workspace-project Exited 0 (fixture; covers rapid double-tap Done single-PATCH guard + Undo + reading-sheet 503 failure retention + reading-sheet Done + Undo)
LOOP_BROWSER=chromium node scripts/heavy-command.mjs scripts/design-scenario.mjs profile-photos-recipient Exited 0 (fixture; covers Quick recipient same-tap context preservation, recipient switch context clear, and <select> sync)
LOOP_BROWSER=chromium node scripts/heavy-command.mjs scripts/design-scenario.mjs main-composer-keyboard Exited 0 (fixture; 390×362 & 320×362 open-keyboard layout with Quick recipient pills visible)
LOOP_BROWSER=chromium node scripts/heavy-command.mjs scripts/design-scenario.mjs needs-stack Exited 0 (fixture)
LOOP_BROWSER=chromium node scripts/heavy-command.mjs scripts/design-scenario.mjs mobile-nav-viewport Exited 0 (fixture; 390 & 320 mobile nav + composer dock alignment)
LOOP_BROWSER=chromium node scripts/heavy-command.mjs scripts/design-scenario.mjs visual-layout Exited 0 (fixture; 320–1920 widths, light & dark themes, zero horizontal overflow)
LOOP_BROWSER=chromium node scripts/heavy-command.mjs scripts/feed-transfer-smoke.mjs Exited 0 (fixture; initialAvatars: 8, afterScrollAvatars: 13, reloadCodeBytes: 0)
GitHub Actions CI (Loop checks/check, tests (1), tests (2), tests (3)) 4/4 passed on a7e9ba87e15d2037a5c1e36066120573011e09e7

Limitations & notes

  • Browser smokes above ran against local Chromium fixtures; WebKit and physical mobile Safari/iOS validation were not run locally.
  • Unrelated pre-existing fixture note: scripts/helpers/design-fixture.mjs does not call publishCompletedRunResult() on its default seeded runs, so older design scenarios that expect sealed Done previews without publishing them (done-card-dismissal, feed-reading, feed-reply-keyboard) fail on main independently of this PR. One-tap Done, rapid double-tap guard, and dismissal-failure coverage were added to workspace-project-smoke.mjs, which publishes a real sealed Result via publishCompletedRunResult().
  • Desktop split-pane/sidebar layout was intentionally left unchanged.

@j-asefa
j-asefa merged commit 06bff52 into main Nov 21, 2026
4 checks passed
@j-asefa
j-asefa deleted the feat/mobile-feed-redesign branch November 21, 2026 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant