Repository navigation
Keep approval refreshes from shifting the Feed - #416
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Routine approval reads previously inserted a loading row above the Feed on every refresh. The current approval list now stays quiet during the first two seconds of a background refresh. If the read stalls, the status and Retry connection control appear. Initial loads and failures still show their status immediately.
Canonical example followed: none: this adjusts the render condition of the existing approval reader.
Submitted commit: b59d81e
The first Loop team review identified that a held same-scope refresh needed a recovery control. The revised browser fixture holds a same-scope read, checks for a quiet refresh, and exercises manual retry on a stalled read.
check: assets
check: assets passed in 0.2 s
check: format
check: format passed in 18.1 s
check: typecheck
check: typecheck passed in 4.0 s
check: openapi
check: openapi passed in 1.1 s
check: sql-index
check: sql-index passed in 0.3 s
check: contracts
check: contracts passed in 144.4 s
check: all passed