Skip to content

Keep approval refreshes from shifting the Feed - #416

Merged
j-asefa merged 3 commits into
mainfrom
fix/quiet-approval-refresh
Nov 21, 2026
Merged

j-asefa merged 3 commits into
mainfrom
fix/quiet-approval-refresh

Conversation

@j-asefa

@j-asefa j-asefa commented Nov 21, 2026 •

Copy link
Copy Markdown
Owner

Routine approval reads previously inserted a loading row above the Feed on every refresh. The current approval list now stays quiet during the first two seconds of a background refresh. If the read stalls, the status and Retry connection control appear. Initial loads and failures still show their status immediately.

Canonical example followed: none: this adjusts the render condition of the existing approval reader.

Submitted commit: b59d81e

The first Loop team review identified that a held same-scope refresh needed a recovery control. The revised browser fixture holds a same-scope read, checks for a quiet refresh, and exercises manual retry on a stalled read.

  • npm run check exited 0.
  • npm run build exited 0.
  • node scripts/approval-reader-browser-smoke.mjs exited 0 in Chromium and WebKit. These were HTTP fixtures.
  • GitHub CI passed check and all three test shards on the submitted commit. Local npm test -- --shard=N/3 --maxWorkers=1 ran with an isolated TMPDIR. Shards 1 and 2 exited 1 (16 and 2 failures respectively). The checkout and trace files passed all 51 tests in an isolated rerun. The migration fixture passed using in-memory temporary storage. Both slow fleet tests passed in isolation with --testTimeout=30000. Shard 3 exited 0 (1096 tests passed).

check: assets
check: assets passed in 0.2 s
check: format
check: format passed in 18.1 s
check: typecheck
check: typecheck passed in 4.0 s
check: openapi
check: openapi passed in 1.1 s
check: sql-index
check: sql-index passed in 0.3 s
check: contracts
check: contracts passed in 144.4 s
check: all passed

@j-asefa
j-asefa merged commit 2e69a8b into main Nov 21, 2026
4 checks passed
@j-asefa
j-asefa deleted the fix/quiet-approval-refresh branch November 21, 2026 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant