Skip to content

Fix ESLint workflow #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
j0code wants to merge 7 commits into from
Closed

Fix ESLint workflow #15

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a659714
fix(eslint): potential fix + debug
j0code May 10, 2026
2fefd82
fix(eslint): make ref and commit sha explicit
j0code May 10, 2026
af1793a
fix(eslint): use head commit for pr sarif uploads
j0code May 10, 2026
7be10ab
fix(eslint): correct syntax in debug echo command
j0code May 10, 2026
eee4ee6
fix(eslint): use merge commit again + inspect sarif file
j0code May 10, 2026
abd436b
fix(eslint): correct path for SARIF file inspection
j0code May 10, 2026
b5c8209
fix(eslint): sigh
j0code May 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions .github/workflows/eslint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,13 +41,26 @@ jobs:
SARIF_ESLINT_IGNORE_SUPPRESSED: "true"
run: npx eslint .
--format @microsoft/eslint-formatter-sarif
--output-file eslint-results.sarif
continue-on-error: true
--output-file eslint-results.sarif || true
continue-on-error: false

- name: "Debug: commit ref and sha"
run: |
echo "event: ${{ github.event_name }}"
echo "ref: ${{ github.ref }}
echo "sha: ${{ github.sha }}

- name: "Debug: Inspect SARIF"
run: |
cat eslint-results.sarif | jq '.runs[0].tool.driver.name'
cat eslint-results.sarif | jq '.runs | length'

- name: Upload analysis results to GitHub
env:
FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: "true"
uses: github/codeql-action/upload-sarif@v4
with:
sarif_file: client/eslint-results.sarif
ref: ${{ github.ref }}
sha: ${{ github.sha }}
wait-for-processing: true
Loading