fix(ui+sdk+demos): popup broadcasts auth_ready until contract arrives - #601
Open
jacoby149 wants to merge 1 commit into
Open
fix(ui+sdk+demos): popup broadcasts auth_ready until contract arrives#601jacoby149 wants to merge 1 commit into
jacoby149 wants to merge 1 commit into
Conversation
…, demos send contract from login button click
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two fixes:
Popup broadcasts auth_ready until it receives a contract (not just once on mount). This way, contractRequest can fire at any time and the popup will respond.
Demos send contract from login button click (same user gesture that opens the popup). This ensures the popup is open when contractRequest fires.
The popup closes normally after contract approval. No lingering.