Groups default not-discoverable (D53 amend) + working contract policy editors - #699
Merged
Merged
Conversation
…t not-discoverable + working contract policy editors + torture tests (3.22.0)
…lt-not-discoverable
…22.0, D55 took 3.23.0) + restore blank line between changelog entries
…lt-not-discoverable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Groups now default to not discoverable (D53 amendment) — listing is an opt-in, so app-backend groups (notes, messages, DMs) stay out of the directory; a one-time, sentinel-gated backfill delists groups created under the old default. The authenticator's group contract editors now work end-to-end: the
SettingsTODO becomes a real join-policy editor, and the roles editor + discoverable toggle are verified through the real UI →POST /v3/groups/update→ persisted. Also fixes agroupDisplayNamebug (it derived the name from the wrong path segments —users/<username>— so every group looked identical; now it returns the slug). Adds an 11-test e2e torture spec (API floor + browser gauntlet + I3 / empty-name / save-failure anti-tests) plus API + UI unit tests. 789 API + 105 UI green, ruff +tsc -bclean, existinggroups-demoe2e (30) green.