test(api): the tagged-post ad conformance floor (D55) — the ads lane's foundation (3.25.0) - #701
Merged
Merged
Conversation
…s foundation (3.25.0) An ad is a posts doc tagged ad (leaf-typed offer + status), not a service — the API has zero ad-specific branches, so the conformance is that the ad post is indistinguishable from a post except its tag + body fields. Pinned by api/tests/test_ads.py (5 tests): create through the existing posts CRUD, the feed read returns it interleaved with posts, I3 (a non-follower gets nothing), and status is a plain body field the read does not filter (D51). Plus a SQL-level pin: the feed read query filters on neither tags nor status. No production code changed. 795 API tests green, ruff clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The ads lane's foundation item: pin the tagged-post ad conformance (D55) with
api/tests/test_ads.py.An ad is a
postsdoc taggedad(a leaf-typedoffer+ astatus), not a service — so the API has zero ad-specific branches, and the conformance is that the ad post is indistinguishable from a post except its tag + body fields.The 5 tests
/v3/createonposts(noadsservice, no new endpoint) withtags=["ad"]+ the leaf-typedoffer+statusin the body, attached to the creator's followers group.read_documents_in_groupsover the followers group returns the ad interleaved with normal posts: same shape, same keys, the ad fields are the only delta.tagscolumn but filters on neither tags nor status (statusis a body field, not a column — it cannot be filtered in SQL at all).Notes
offer/ad-tag branches inapi/app/v3/).KB:
knowledge/knowledge-base/web10-v3/social/ads.md(D55) +ads-catalog.md.