Skip to content

Add announcer styles and ESLint hardening - #16

Merged
jaden688 merged 3 commits into
mainfrom
codex/make-dailycast-deployable-and-enhance-ui
Dec 21, 2025
Merged

jaden688 merged 3 commits into
mainfrom
codex/make-dailycast-deployable-and-enhance-ui

Conversation

@jaden688

Copy link
Copy Markdown
Owner

Summary

  • add announcer style catalog, profile preferences, style APIs, and style-aware script rendering for episode generation
  • extend profile UI with announcer style selection, intensity slider, and preview using backend styles endpoints
  • harden lint configuration with Next.js ESLint defaults, ignore file, strict lint scripts, and CI lint job flags

Testing

  • python -m compileall backend/app
  • npm run lint (fails: eslint/eslint-config-next download blocked by registry proxy; lint still non-interactive once packages are available)

Codex Task

@vercel

vercel Bot commented Dec 21, 2025 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
daily-cast Error Error Dec 21, 2025 8:16pm

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread backend/alembic/env.py
Comment on lines +23 to +26

async with connectable.connect() as connection:
await connection.run_sync(Base.metadata.create_all)
await connection.run_sync(do_run_migrations)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Alembic env pre-creates tables before migrations

The Alembic env runs Base.metadata.create_all before executing migrations. On a fresh database, alembic upgrade head will create all tables from the latest models and then immediately try to run revision 0001/0002, causing the op.create_table calls to fail with “relation already exists” and preventing the app from starting (the entrypoint runs this command on container boot). Drop the create_all call and rely on the migrations to create the schema.

Useful? React with 👍 / 👎.

Comment thread docker-compose.yml
Comment on lines +34 to +37
context: .
dockerfile: backend/Dockerfile
env_file:
- backend/.env.example

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge docker-compose env_file paths point to missing files

Both backend services declare env_file: backend/.env.example (and the frontend uses frontend/.env.example later in the file), but neither of those files exists in the repo—the only example env is ./.env.example. As written, docker compose up exits immediately with “environment file … not found” before any services start. Point env_file at an existing file or add the missing examples.

Useful? React with 👍 / 👎.

@jaden688
jaden688 merged commit 742a884 into main Dec 21, 2025
5 of 6 checks passed
@jaden688
jaden688 deleted the codex/make-dailycast-deployable-and-enhance-ui branch December 21, 2025 20:17

This branch was previously deployed

1 inactive deployment
Preview — 51965be5 Deployed Dec 21, 2025 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant