Repository navigation
Add announcer styles and ESLint hardening - #16
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| async with connectable.connect() as connection: | ||
| await connection.run_sync(Base.metadata.create_all) | ||
| await connection.run_sync(do_run_migrations) |
There was a problem hiding this comment.
Alembic env pre-creates tables before migrations
The Alembic env runs Base.metadata.create_all before executing migrations. On a fresh database, alembic upgrade head will create all tables from the latest models and then immediately try to run revision 0001/0002, causing the op.create_table calls to fail with “relation already exists” and preventing the app from starting (the entrypoint runs this command on container boot). Drop the create_all call and rely on the migrations to create the schema.
Useful? React with 👍 / 👎.
| context: . | ||
| dockerfile: backend/Dockerfile | ||
| env_file: | ||
| - backend/.env.example |
There was a problem hiding this comment.
docker-compose env_file paths point to missing files
Both backend services declare env_file: backend/.env.example (and the frontend uses frontend/.env.example later in the file), but neither of those files exists in the repo—the only example env is ./.env.example. As written, docker compose up exits immediately with “environment file … not found” before any services start. Point env_file at an existing file or add the missing examples.
Useful? React with 👍 / 👎.
Summary
Testing
python -m compileall backend/appnpm run lint(fails: eslint/eslint-config-next download blocked by registry proxy; lint still non-interactive once packages are available)Codex Task