Repository navigation
Align Delivery Mode 'Savage' styling with theme - #20
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b6ac4c4714
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| router.delete('/:feedId', requireAuth, async (req: AuthRequest, res) => { | ||
| await prisma.feedConnection.delete({ where: { id: req.params.feedId } }); |
There was a problem hiding this comment.
Restrict feed deletions to the owning user
This delete handler removes a feed by ID without scoping the query to req.userId. Any authenticated user who can obtain or guess another feed UUID can delete someone else’s feed because prisma.feedConnection.delete only checks id. Consider using a deleteMany with id + userId or first verifying ownership before deletion so the API enforces per-user access control.
Useful? React with 👍 / 👎.
| router.delete('/:episodeId', requireAuth, async (req: AuthRequest, res) => { | ||
| await prisma.episode.delete({ where: { id: req.params.episodeId } }); |
There was a problem hiding this comment.
Restrict episode deletions to the owning user
This delete handler deletes episodes by ID without checking req.userId, so any authenticated user can delete another user’s episode if they learn the UUID. Because prisma.episode.delete only filters by id, it bypasses authorization. Add an ownership check (e.g., deleteMany with id + userId or a prior lookup) to enforce per-user access.
Useful? React with 👍 / 👎.
Motivation
Description
src/components/delivery-mode-selector.tsxto introduceisSavageand apply an amber gradient/ring/shadow for thesavagecard highlight.savageand refined theBadgeclasses to use amber-focused border/background/text so the new-mode label reads against the dark theme.DELIVERY_MODESand the existingonChangecallback.Testing
npm testand the suite completed successfully (all tests passed).npm run buildwhich completed successfully but emitted non-blocking warnings from a third-party package's dynamic imports.artifacts/delivery-mode-theme.pngshowing the updated UI (initial Chromium attempt timed out; a subsequent run produced the artifact).Codex Task