Skip to content

GZIP + Error: ENOENT: no such file or directory #15

Description

@belaa007

If you use gzip: true, and the file doesn't exist, the module throws an unhandles exception:
{ Error: ENOENT: no such file or directory, open 'asd' errno: -2, code: 'ENOENT', syscall: 'open', path: 'asd' }

The issue is in the big-xml.js file, starting line 20:

  if (options.gzip) {
    var gunzip = zlib.createGunzip();
    stream.pipe(gunzip);
    stream = gunzip;
  }

After this, in line 34, there is indeed an intended error handling:

  stream.on('error', function(err) {
    self.emit('error', new Error(err));
  });

But since here the stream variable is not
var stream = fs.createReadStream(filename);
anymore, it cannot catch errors from from the original stream variable.

My idea to fix this would be to raise the stream.on before the if block, and add a plus error listener in the if block :

  stream.on('error', function(err) {
    self.emit('error', new Error(err));
  });
    
  if (options.gzip) {
    var gunzip = zlib.createGunzip();
    gunzip.on('error', function(err) {
      self.emit('error', new Error(err));
    });
    stream.pipe(gunzip);
    stream = gunzip;
  }

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions