Fix build on Apple Silicon (arm64), modernize a few deprecated AppKit calls - #112
Open
andreabrugnoli wants to merge 1 commit into
Open
andreabrugnoli wants to merge 1 commit into
andreabrugnoli wants to merge 1 commit into
Conversation
- raise MACOSX_DEPLOYMENT_TARGET from 10.8 to 11.0 (below current Xcode's minimum supported deployment target, 10.13; 11.0 is also the first macOS release for Apple Silicon) - drop leftover Swift bridging-header build settings (no .swift files exist in the project) - replace deprecated NSRightTextAlignment/NSLeftTextAlignment/ NSCenterTextAlignment, NSStringPboardType, NSFileHandlingPanelOKButton, NSOnState/NSOffState with their modern equivalents Verified: clean Release build with current Xcode produces a native arm64 binary, app launches and opens/saves CSV files without issue, existing test suite passes unchanged. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The project hasn't been touched since 2020, before Apple Silicon Macs existed, and no longer builds cleanly with current Xcode. This PR is a small, non-invasive fix, no new features, no behavior change:
MACOSX_DEPLOYMENT_TARGETfrom 10.8 to 11.0. Current Xcode's minimum supported deployment target is 10.13, so 10.8 now produces a build warning; 11.0 is also the first macOS release that shipped on Apple Silicon..swiftfiles anywhere in the project, so these were dead configuration.NSRightTextAlignment/NSLeftTextAlignment/NSCenterTextAlignment→NSTextAlignment*,NSStringPboardType→NSPasteboardTypeString,NSFileHandlingPanelOKButton→NSModalResponseOK,NSOnState/NSOffState→NSControlStateValue*.No source logic changes beyond the constant renames above.
Verified locally on an Apple Silicon Mac: clean
xcodebuildRelease build produces a native arm64 binary, the app launches and opens/saves both comma- and semicolon-separated CSV files without issue, and the existing XCTest suite (33 tests) passes unchanged.I know the project has been quiet for a while — happy to adjust anything if you'd rather keep the deployment target lower, or split this differently.
🤖 Generated with Claude Code