feat(cli): add a per-stage accept-all to curate and honor review (#385) - #509
Merged
Conversation
Closes #385. A test run needed 74 individual confirmations in the Structure stage alone, while `openkos.yaml` had carried `review: true` all along and this verb never read it -- 16 sites in `main.py` already did. `curate --accept structure,metadata` answers those stages' per-item write prompts without asking, and `review: false` does the same for every acceptable stage when no flag is passed. Identity is excluded structurally, with three independent guards, because the failure mode is a silently deleted concept: - `auto_acceptable` is a field on the stage descriptor and Identity keeps the `False` default, so a future writing stage cannot inherit accept-all merely by being added to `_STAGES`; - `--accept identity` is refused with exit 2, and `review: false` only ever populates the acceptable stages; - Identity's walk calls `_confirm` directly rather than through `_confirm_item`, so the acceptance path cannot reach it at all. Naming a stage IS per-item write consent, so an accepted stage also passes the non-TTY write refusal: `curate --auto --accept structure` writes on a pipe, which is parity with `suggest-relations --auto` rather than new authority. Identity remains refused on that path. An unknown stage name is refused the same way, and both refusals run before the workspace gate so a typo reports as itself rather than as a missing workspace -- the ordering `list`'s TYPE already uses. An explicit `--accept` overrides `review` and names the exact set instead of widening it, so an operator running with `review: false` can still re-review one stage without editing the config mid-session. Confidence-threshold auto-acceptance is deliberately out of scope and filed as #508: `EdgeSuggestion` and `TierSuggestion` expose no confidence at all, so a threshold is implementable today only on Identity, which may never be accepted in bulk. Spec, docs and CHANGELOG updated. Suite 4040 -> 4048.
This was referenced Aug 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #385. Follow-up filed as #508.
A test run needed 74 individual confirmations in the Structure stage alone, while
openkos.yamlhad carriedreview: trueall along and this verb never read it. Measuring first:cfg.reviewis honored in 16 sites inmain.pyand zero incurate.py.The deeper cause is an asymmetry.
curate --autoconsents to model spend, never to a per-item write (design rule D3), and its escape hatch is theunattended_hintpointing at the standalone verb — where--autodoes write. Sosuggest-relations --autohas always written 74 relations unattended whilecurate --autowrote none.What ships
curate --accept structure,metadataanswers those stages' per-item prompts without asking.review: falsedoes the same for every acceptable stage when no flag is passed.Identity is excluded structurally — three independent guards
A merge absorbs one concept into another and deletes the absorbed file. One guard is not enough when the failure mode is a silently destroyed concept:
auto_acceptableis a field on theStagedescriptor and Identity keeps theFalsedefault. A future writing stage cannot inherit accept-all merely by being added to_STAGES.--accept identityis refused with exit 2, andreview: falseonly ever populates acceptable stages._confirmdirectly rather than through_confirm_item, so the acceptance path cannot reach it at all.This is load-bearing, not belt-and-braces. Mutating guard 1 alone does not make merges silent; mutating guards 1 and 2 together does, and the test catches it. There is also a fourth surface: the non-TTY write refusal is lifted by
accepted_stagesmembership, so if Identity ever became acceptable it would gain unattended merge authority — concepts deleted by a config line and a pipe, with no prompt anywhere to decline at. That path has its own test, and mutating it produces an exit-1 crash rather than a silent merge.Other decisions
--acceptIS write consent, so an accepted stage passes the non-TTY refusal.curate --auto --accept structurewriting on a pipe is parity withsuggest-relations --auto, not new authority.--acceptnarrows rather than widensreview: false. A flag that could only ever add would leave an operator no way to re-review one stage without editing the config mid-session.curate --accept strctureoutside a workspace reports the typo as itself — the orderinglist'sTYPEandset-volatility's tier already use.Confidence thresholds are out of scope, and the issue's plan was inverted
#385 proposed auto-accepting above 0.9. That is not implementable on the stages that hurt:
EdgeSuggestioncarriesedge/suggested_type/rationaleandTierSuggestioncarriestype_name/current_default/suggested_tier— neither has confidence. The onlyconfidencein the project lives inadjudication.py, i.e. Identity, the destructive stage. Filed as #508, which has to add confidence to the suggesters first (a prompt change, so it needs a cap-harness A/B, not just a green suite).Verification
ruffandmypyclean over the whole repo.Disclosure: no review receipt
Same lens defect as PRs #503, #506 and #507: the review agents are configured with only Read/Grep/Glob and cannot run the read-only Git commands the contract requires, so inspection returns
incomplete. Shipping without a receipt is the maintainer's standing decision this session.