Repository navigation
Make discrete-factor sensitivity and shared-group validation explicit - #222
Merged
Merged
Conversation
Collaborator
Author
|
Independent agent review approved exact head All 11 hosted checks now pass on that head, including Python3.10–3.13, clean wheel, examples, older numerical stack and the aggregate gate. Exact-head local qualification passed 989 source and 989 installed-wheel tests, 67 older-stack cases without skips, strict quality/types/docs and distribution checks. Merge uses the maintainer-authorized review override after both required gates are satisfied. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A pooled results table could silently drop discrete capacity/rules from sensitivity analysis, concealing their effects or attributing them to continuous settings. Refuse varying discrete/categorical factors and undeclared varying configuration keys. Add explicit observed-stratum
condition_onselection, bind observed constants (including continuous inputs made constant by conditioning), screen only varying continuous factors, and return scope, target bounds/log scales, original row identities and marginal support.Forward actual grouped validation and retain grouped/row R² and RMSE without substituting row metrics when groups are unavailable. Add explicit
cv_groupsfor shared dataset/replicate partitions crossing designs; validate the full original ordered vector before conditioning, merge equal finite numeric identities, retain labels/source/IDs and reject missing labels, unordered/mapping inputs and conflicting group sources. Reuse the existing surrogate GroupKFold path. One partition does not automatically block crossed dependencies.The complete executable guide uses direct factorial/paired contrasts for discrete effects, explains why conditional Sobol indices do not measure q or its interactions, and states independent uniform/log-uniform sampling and joint-support limits. No frozen study, environment, manuscript or consumer pin changes.
Qualification covers q-only outcomes, q×log-prior interactions/confounding, analytic conditional 0.8/0.2 indices, constant dimensions, hidden keys, held-out design/dataset validation, row-CV leakage, source alignment, GP/RF and the full guide. A required older-stack job runs all selected scope/group tests without skips on Python3.11/NumPy1.24/scikit-learn1.3.2/SALib1.5.0/SciPy1.11.4/pandas2.0.3.
Final committed head:
0f3aa346d8cc36cd56f84eb5d0b94947762875e7. Full source and clean installed wheel each passed 989 tests; all 67 selected older-stack cases passed without skips. Strict Ruff, full source mypy, strict documentation, distribution metadata and figure checks passed. An independent agent approved this exact head and independently reran all 21 external-group cases after its unordered-vector finding was fixed; the broader independent run passed 61 cases. Hosted CI remains a merge gate.Closes #220.