Repository navigation
feat: 进度条progress组件视频进度条支持 #3533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
wangqiking
wants to merge
6
commits into
jdf2e:feat_v4.x
Choose a base branch
from
wangqiking:feat_v4_progress_video
base: feat_v4.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
08c78cd
feat: 进度条progress组件视频进度条支持
wangqiking 148f721
fix: 修改aicr问题
wangqiking 04b7191
Merge branch 'feat_v4.x' into feat_v4_progress_video
xiaoyatong 5c3abd1
fix: 修改taro版本样式
wangqiking 09cdb44
Merge branch 'feat_v4_progress_video' of github.com:wangqiking/nutui-…
wangqiking 3e284f3
Merge branch 'feat_v4.x' into feat_v4_progress_video
xiaoyatong File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| import React, { useState } from 'react' | ||
| import { Progress, Cell } from '@nutui/nutui-react' | ||
|
|
||
| const cardStyle: React.CSSProperties = { | ||
| padding: '15px 18px', | ||
| background: '#999', | ||
| borderRadius: 8, | ||
| marginBottom: 12, | ||
| } | ||
|
|
||
| const progressStyle: React.CSSProperties = { | ||
| height: 38, | ||
| } | ||
|
|
||
| const Demo10 = () => { | ||
| const [percent, setPercent] = useState(20) | ||
| return ( | ||
| <Cell.Group> | ||
| <Cell style={cardStyle} align="center"> | ||
| <Progress | ||
| mode="video" | ||
| status="static" | ||
| percent={30} | ||
| style={progressStyle} | ||
| /> | ||
| </Cell> | ||
| <Cell style={cardStyle}> | ||
| <Progress | ||
| mode="video" | ||
| status="paused" | ||
| percent={50} | ||
| style={progressStyle} | ||
| /> | ||
| </Cell> | ||
| <Cell style={cardStyle}> | ||
| <Progress | ||
| mode="video" | ||
| percent={percent} | ||
| draggable | ||
| onChange={(p) => setPercent(p)} | ||
| style={progressStyle} | ||
| /> | ||
| </Cell> | ||
| </Cell.Group> | ||
| ) | ||
| } | ||
| export default Demo10 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| import React, { useState } from 'react' | ||
| import { Progress } from '@nutui/nutui-react-taro' | ||
| import { View } from '@tarojs/components' | ||
|
|
||
| const cardStyle: React.CSSProperties = { | ||
| padding: '15px 18px', | ||
| background: '#999', | ||
| borderRadius: 8, | ||
| marginBottom: 12, | ||
| } | ||
|
|
||
| const progressStyle: React.CSSProperties = { | ||
| height: 38, | ||
| } | ||
| const Demo10 = () => { | ||
| const [percent, setPercent] = useState(20) | ||
| return ( | ||
| <> | ||
| <View style={cardStyle}> | ||
| <Progress | ||
| mode="video" | ||
| status="static" | ||
| percent={30} | ||
| style={progressStyle} | ||
| /> | ||
| </View> | ||
| <View style={cardStyle}> | ||
| <Progress | ||
| mode="video" | ||
| status="paused" | ||
| percent={55} | ||
| style={progressStyle} | ||
| /> | ||
| </View> | ||
| <View style={cardStyle}> | ||
| <Progress | ||
| mode="video" | ||
| percent={percent} | ||
| draggable | ||
| onChange={(p) => setPercent(p)} | ||
| style={progressStyle} | ||
| /> | ||
| </View> | ||
| </> | ||
| ) | ||
| } | ||
| export default Demo10 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
补充容器高度变量的类型。
NutCSSVariables缺少nutuiProgressVideoContainerHeight。所有新增主题变量都定义了--nutui-progress-video-container-height。因此,使用ConfigProvider的类型化主题配置时,调用方无法配置该变量。建议修改
| 'nutuiProgressVideoOpacityStatic' | 'nutuiProgressVideoOpacityPaused' + | 'nutuiProgressVideoContainerHeight'📝 Committable suggestion
🤖 Prompt for AI Agents