Repository navigation
Feat/typescript 7 #30
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,2 @@ | ||
| # [install] | ||
| # minimumReleaseAge = 604800 | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,20 +1,20 @@ | ||
| { | ||
| "name": "@jfa.dev/landing", | ||
| "version": "0.3.5", | ||
| "private": true, | ||
| "type": "module", | ||
| "scripts": { | ||
| "build": "vp build", | ||
| "cf-typegen": "wrangler types", | ||
| "check": "vp run typecheck && vp check", | ||
| "deploy": "vp run typecheck && vp lint && vp build && wrangler deploy", | ||
| "dev": "vp dev --port 3000 --host", | ||
| "format": "vp fmt", | ||
| "lint": "vp lint", | ||
| "preview": "vp preview", | ||
| "serve": "vp preview", | ||
| "test": "vp test", | ||
| "typecheck": "tsc --noEmit" | ||
| }, | ||
| "dependencies": { | ||
| "@base-ui/react": "catalog:react-ui", | ||
|
|
@@ -38,7 +38,6 @@ | |
| "devDependencies": { | ||
| "@types/react": "catalog:types", | ||
| "@types/react-dom": "catalog:types", | ||
| "@vitejs/plugin-react": "catalog:build", | ||
| "typescript": "catalog:build", | ||
| "vite": "catalog:build", | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -59,15 +59,6 @@ function RootDocument({ children }: { children: React.ReactNode }) { | |
| <a href="https://github.com/jfalava" className="sr-only" rel="me"> | ||
| GitHub | ||
| </a> | ||
| </body> | ||
| </html> | ||
| ); | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -6,14 +6,14 @@ | |
| "scripts": { | ||
| "build": "vp build", | ||
| "cf-typegen": "wrangler types", | ||
| "check": "vp run typecheck && vp check", | ||
| "deploy": "vp run typecheck && vp lint && vp build && wrangler deploy", | ||
| "dev": "vp dev --port 3000 --host", | ||
| "format": "vp fmt", | ||
| "lint": "vp lint", | ||
| "preview": "vp preview", | ||
| "serve": "vp preview", | ||
| "typecheck": "tsc --noEmit" | ||
|
Comment on lines
+9
to
+16
There was a problem hiding this comment. 🩺 Stability & Availability | 🟡 Minor | ⚡ Quick win 🧩 Analysis chain🏁 Script executed: #!/bin/bash
# Compare deploy chains across all packages
rg -n '"deploy"' --type=json -g '*package.json' -A1
# Investigate what vp check does vs vp lint + vp build
rg -n 'vp check' --type=json -g '*package.json' -B2 -A2Repository: jfalava/jfa.dev Length of output: 153 🏁 Script executed: #!/bin/bash
set -euo pipefail
echo "== package.json files =="
git ls-files '*package.json'
echo
echo "== deploy/check scripts across package.json files =="
python3 - <<'PY'
import json, pathlib
for p in sorted(pathlib.Path('.').rglob('package.json')):
try:
data = json.loads(p.read_text())
except Exception:
continue
scripts = data.get('scripts', {})
if any(k in scripts for k in ('deploy','check','lint','build','typecheck')):
print(f'-- {p}')
for k in ('check','deploy','lint','build','typecheck'):
if k in scripts:
print(f' {k}: {scripts[k]}')
PY
echo
echo "== any direct vp check references =="
rg -n --glob 'package.json' 'vp check|vp run check|vp run typecheck|wrangler deploy|vp lint|vp build' .
echo
echo "== files mentioning vp check outside package.json =="
rg -n 'vp check|vp run check' .Repository: jfalava/jfa.dev Length of output: 2739 Use 🤖 Prompt for AI Agents |
||
| }, | ||
| "dependencies": { | ||
| "@base-ui/react": "catalog:react-ui", | ||
|
|
@@ -26,7 +26,7 @@ | |
| "clsx": "catalog:styling", | ||
| "html-to-image": "1.11.13", | ||
| "lucide-react": "catalog:react-ui", | ||
| "nanoid": "5.1.16", | ||
| "react": "catalog:react-ui", | ||
| "react-dom": "catalog:react-ui", | ||
| "tailwind-merge": "catalog:styling", | ||
|
|
@@ -40,7 +40,6 @@ | |
| "@types/node": "catalog:types", | ||
| "@types/react": "catalog:types", | ||
| "@types/react-dom": "catalog:types", | ||
| "@vitejs/plugin-react": "catalog:build", | ||
| "jsdom": "29.1.1", | ||
| "shadcn": "catalog:react-ui", | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔒 Security & Privacy | 🟠 Major | ⚡ Quick win
Disabling
minimumReleaseAgeremoves a supply chain safety net.minimumReleaseAge = 604800enforced a 7-day quarantine for newly published packages. Commenting it out means Bun will happily install packages published seconds ago — including potentially compromised or buggy ones. Given this PR bumps a massive swath of dependencies to bleeding-edge versions, disabling this guardrail right now is the worst possible timing.If the intent was to install versions younger than 7 days, re-enable this setting after the update lands. Leaving it disabled permanently is reckless.
🔒️ Proposed fix: re-enable after updates are applied
📝 Committable suggestion
🤖 Prompt for AI Agents