Record special bits in store identity - #46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New packages use manifest.v3 and a domain-separated v3 content hash.
Before v3, Mere preserved setuid, setgid, and sticky bits when packaging and extracting files, but did not include them in the content hash. That created a semantic hole: two packages could share the same store identity while behaving differently.
For example:
V3 closes that gap by including the three special bits for regular files and directories in the hash. It deliberately continues excluding ownership and ordinary read/write permissions because those are changed by installation context and hardening. Symlink modes remain excluded because they are not meaningful on Linux.