Fail closed when manim.font, quality, or manim_path is a list - #106
Merged
Merged
Conversation
YAML lists were str()'d into a bogus font name, a quality string that silently fell back to 720p30, or a nonexistent manim binary path. Require those present keys to be non-empty YAML strings at config load. Co-authored-by: jmjava <jmjava@gmail.com>
ruff, pytest (631 passed, 1 skipped), and docgen benchmark are green. Co-authored-by: jmjava <jmjava@gmail.com>
jmjava
marked this pull request as ready for review
September 7, 2026 20:55
Co-authored-by: jmjava <jmjava@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
YAML lists for
manim.font,manim.quality, andmanim.manim_pathwere coerced withstr():"['Liberation Sans']"and Manim used a bogus family"['1080p30']", missed the preset map, and silently fell back to 720p30"['/usr/bin/manim']"and binary lookup failed laterThis PR requires those present keys to be non-empty YAML strings at
Config.__post_init__. Missing keys still use defaults (Liberation Sans,1080p30, no path).Test plan
ruff check src/ tests/test_from_yaml_list_manim_font_raises,_quality_raises,_path_raisespytest tests/— 631 passed, 1 skippeddocgen benchmarkvssrc/docgen/benchmark_data/baseline.json(quality average 100.0)Milestone
milestones/manim-font-quality.md