Fail closed when narration or scene-generation model is a list - #107
Merged
Merged
Conversation
YAML lists for narration_from_source.model / system_prompt and manim_scene_generation.model / system_prompt / scene_spec_system_prompt were str()'d into bracketed strings sent to the chat API. Require those present keys to be YAML strings at config load. Co-authored-by: jmjava <jmjava@gmail.com>
ruff, pytest (636 passed, 1 skipped), and docgen benchmark are green. Co-authored-by: jmjava <jmjava@gmail.com>
jmjava
marked this pull request as ready for review
September 7, 2026 21:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
YAML lists for
narration_from_source.model/system_promptandmanim_scene_generation.model/system_prompt/scene_spec_system_promptwere coerced withstr()into values like"['gpt-4o']"and sent to the chat API as the model name or system prompt.This PR requires those present keys to be YAML strings at
Config.__post_init__.modelmust be non-empty;system_prompt/scene_spec_system_promptmay be empty (same aswizard.system_prompt). Missing keys still use code defaults.Test plan
ruff check src/ tests/pytest tests/— 636 passed, 1 skippeddocgen benchmarkvssrc/docgen/benchmark_data/baseline.json(quality average 100.0)Milestone
milestones/generation-model-strings.md