Fail closed when discovery flags are not YAML booleans - #114
Merged
Merged
Conversation
yaml-generate used identity `is False` for auto_visual_map and merge_hint_segments. Integer 0 and quoted "false" did not opt out, so discovery could still rewrite visual_map and hint merges still ran. Co-authored-by: jmjava <jmjava@gmail.com>
Record PR #114 and pytest / benchmark results on the milestone. Co-authored-by: jmjava <jmjava@gmail.com>
jmjava
marked this pull request as ready for review
September 7, 2026 21:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
yaml-generatetreatsdiscovery.auto_visual_map: falseas the opt-out that keeps a committedvisual_map, anddiscovery.merge_hint_segments: falseas the opt-out that skips hint-driven segment / wiring merges.Those checks used identity
is False. YAML integer0and the quoted string"false"are not the booleanFalse, so discovery still ran (and could rewritevisual_map) and hint merges still applied.Change
discovery.auto_visual_map/discovery.merge_hint_segmentsto be YAML booleans atConfig.from_yaml.yaml-generateso a hint merge cannot inject0/"false"after load.false/trueand missing keys keep current behavior.Milestone:
milestones/discovery-bool-flags.mdTests
auto_visual_map: 0and"false".discover_visual_map/merge_hint_declared_segmentsraise instead of silently continuing.