Fail closed when pipeline numeric tunables are not YAML numbers - #115
Merged
Merged
Conversation
bool is a subclass of int, so compose.ffmpeg_timeout_sec: true became timeout 1 and manim.min_font_size: true became font size 1. Lists and strings TypeError'd later in timestamps/compose/validate. Co-authored-by: jmjava <jmjava@gmail.com>
Record PR #115 and pytest / benchmark results on the milestone. Co-authored-by: jmjava <jmjava@gmail.com>
jmjava
marked this pull request as ready for review
September 7, 2026 21:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Config properties wrap timestamps / compose / manim / validation tunables in
int()/float(). A YAML bool is a subclass ofint, so:compose.ffmpeg_timeout_sec: truebecame timeout 1 secondmanim.min_font_size: truebecame font size 1validation.max_freeze_ratio: truebecame 1.0 (allow a fully frozen video)A YAML list or string raised
TypeError/ValueErrorduring timestamps, compose, or validate — notConfigErrorat load.Change
Present values of
timestamps.silence_noise_db/min_silence_sec,manim.min_font_size,compose.ffmpeg_timeout_sec, andvalidation.max_drift_sec/max_freeze_ratiomust be YAML numbers (int or float, not bool). Missing keys keep defaults.Milestone:
milestones/numeric-config-tunables.mdTests
ffmpeg_timeout_sec/min_font_sizerejectedsilence_noise_db/max_drift_sec/max_freeze_ratiorejectedmin_silence_secrejected