Fail closed when nested validation tunables are not YAML numbers - #118
Merged
Merged
Conversation
bool is a subclass of int, so av_sync.tolerance_sec: true became 1.0s OCR slack and ocr.min_confidence: true became 1. Co-authored-by: jmjava <jmjava@gmail.com>
Record PR #118 and pytest / benchmark results on the milestone. Co-authored-by: jmjava <jmjava@gmail.com>
jmjava
marked this pull request as ready for review
September 7, 2026 21:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Top-level
validation.max_drift_sec/max_freeze_ratioare already typed. Nested check tunables still go throughint()/float(). A YAML bool is a subclass ofint, so:validation.av_sync.tolerance_sec: truebecame 1.0s OCR slackvalidation.ocr.min_confidence: truebecame 1validation.story_end.max_early_sec: truebecame 1sA YAML list or string raised
TypeError/ValueErrorinside validate, notConfigErrorat load.Change
Present values of nested OCR / layout / av_sync / timing_sync / story_end numerics must be YAML numbers (int or float, not bool). Missing keys keep defaults. Enable flags are unchanged.
Milestone:
milestones/validation-numeric-tunables.mdTests
tolerance_sec/max_early_secrejectedmin_confidencerejectedmax_tail_gap_secrejected