Fail closed when validation enable flags are not YAML booleans - #119
Merged
Merged
Conversation
Quoted enabled: "false" is truthy, so av_sync and scene_lint stayed on. Integer 0 disabled subject-beat coverage via bool(0) instead of failing. Co-authored-by: jmjava <jmjava@gmail.com>
Record PR #119 and pytest / benchmark results on the milestone. Co-authored-by: jmjava <jmjava@gmail.com>
jmjava
marked this pull request as ready for review
September 7, 2026 21:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Nested validation numerics are typed. Enable flags still used Python truthiness /
bool():validation.av_sync.enabled: "false"is a non-empty string, so the check stayed onmanim.scene_lint: "false"kept scene lint onsubject_beat_coverage.enabled: 0disabled coverage viabool(0)instead of failing closedYAML
false/truealready work.Change
Present values of
manim.scene_lint,validation.layout.check_overlap,av_sync.enabled/prefer_scene_spec_labels,timing_sync.enabled,scene_assets.enabled,story_end.enabled, andsubject_beat_coverage.enabledmust be YAML booleans. Missing keys keep defaults.Milestone:
milestones/validation-enable-bools.mdTests
"false"onav_sync.enabled/scene_lintrejected0onsubject_beat_coverage.enabledrejected