Fail closed when concat ffmpeg leaves a truncated output - #123
Merged
Merged
Conversation
Concat already raised ConcatError on timeout or non-zero ffmpeg, but left recordings/<target>.mp4 in place. Unlink the incomplete file so pages and validate cannot treat a hung concat as a finished demo. Co-authored-by: jmjava <jmjava@gmail.com>
ruff, pytest (709 passed, 1 skipped), and docgen benchmark all green. Co-authored-by: jmjava <jmjava@gmail.com>
jmjava
marked this pull request as ready for review
September 7, 2026 22:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compose now raises and unlinks a partial mux on ffmpeg timeout (#121). Concat already raised
ConcatErroron timeout / non-zero ffmpeg, but it leftrecordings/<target>.mp4in place.ffmpeg -ywrites as it goes, so a hung or failed concat could leave a truncated full-demo file thatpages/ validate treat as a finished recording.This PR unlinks the incomplete concat output on timeout,
CalledProcessError, or missing ffmpeg, matching compose.Milestone:
milestones/concat-ffmpeg-timeout.md. No clock / compile change.Local gates
ruff check src/ tests/— passpytest tests/— 709 passed, 1 skippeddocgen benchmark— meetssrc/docgen/benchmark_data/baseline.json(no--update-baseline)