Use Config.segments_all for CLI narration and scene-spec --all - #125
Merged
Merged
Conversation
narration-generate --all and scene-spec-generate --all read raw segments.all and treated a missing key as empty, so a bundle that only sets segments.default raised even though TTS/lint/pipeline use Config.segments_all (default fallback). Empty all: [] still errors. Co-authored-by: jmjava <jmjava@gmail.com>
ruff, pytest (717 passed, 1 skipped), and docgen benchmark all green. Co-authored-by: jmjava <jmjava@gmail.com>
jmjava
marked this pull request as ready for review
September 7, 2026 22:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
narration-generate --allandscene-spec-generate --allreadraw["segments"]["all"] or []. Missingallwith a populatedsegments.defaultraisedsegments.all is emptyeven thoughConfig.segments_all(TTS, timestamps, lint, pipeline) falls back todefault.This PR uses
cfg.segments_all. An explicit emptyall: []still errors (same as Config after #124).Milestone:
milestones/cli-segments-all.md. No clock / compile change.Local gates
ruff check src/ tests/— passpytest tests/— 717 passed, 1 skippeddocgen benchmark— meetssrc/docgen/benchmark_data/baseline.json(no--update-baseline)