Fail closed when Manim timing helpers see corrupt timing.json - #130
Merged
Merged
Conversation
Compiled scenes.py still used .get(stem, {}).get(segments) so a list
stem raised AttributeError at construct(). Type-check stem objects and
words/segments arrays; refresh stale loaders on scene-compile.
Co-authored-by: jmjava <jmjava@gmail.com>
Co-authored-by: jmjava <jmjava@gmail.com>
jmjava
marked this pull request as ready for review
September 7, 2026 23:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Library
load_bundle_timingnow rejects non-object stems and non-arraywords/segments. Compiledscenes.pystill useddata.get(segment_key, {}).get("segments", []), so a list stem raisedAttributeErrorat Manimconstruct().scene-compiledid not refresh those helpers.Change
Bootstrap
_load_timing/_load_timing_wordsraiseTypeErroron corrupt stem / inner types. Missing file or missing stem still returns[].refresh_bootstrap_helpersandhelper_api_violationstreat the old bodies as stale sodocgen scene-compileupgrades consumerscenes.py.Tests
Local:
ruff check src/ tests/green;pytest tests/750 passed, 1 skipped;docgen benchmarkmeetssrc/docgen/benchmark_data/baseline.json(helper change, no--update-baseline).[]for a missing stemOut of scope
start/endon every word row