Fail closed when wizard source_paths is not a string array - #131
Merged
Merged
Conversation
list(source_paths) treated a JSON string as characters and looked like missing files. Require a string array; type-check guidance/text/mode and focus path items so list values cannot AttributeError on .strip(). Co-authored-by: jmjava <jmjava@gmail.com>
Co-authored-by: jmjava <jmjava@gmail.com>
jmjava
marked this pull request as ready for review
September 7, 2026 23:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
PR #129 required wizard bodies to be JSON objects.
source_pathsstill usedlist(data.get("source_paths") or []). A string is iterable, so"README.md"became['R','E','A',…]and looked like missing files. A listguidance/textlater called.strip()and raisedAttributeError. Focuspathsitems werestr()-coerced.Change
require_json_str_list/require_json_stringsource_paths(when present) must be a JSON array of strings; missing / null still[](hint-path fallback)guidance,segment_name,revision_notes,current_narration,mode,topic_label,segment_id, PUTtextmust be JSON strings when presentpathsitems must be stringsTests
Local:
ruff check src/ tests/green;pytest tests/755 passed, 1 skipped;docgen benchmarkmeetssrc/docgen/benchmark_data/baseline.json(no--update-baseline).source_paths→ 400guidance/text→ 400Out of scope
{}viaget_json(silent=True)except Exceptionaroundnarration_topic_label