Fail closed when wizard JSON bodies do not parse - #132
Merged
Merged
Conversation
get_json(silent=True) returned None for both a missing body and garbage
JSON, so {not-json looked like {}. Parse the raw body; invalid JSON and
JSON null raise WizardError. Empty bodies stay {}.
Co-authored-by: jmjava <jmjava@gmail.com>
jmjava
marked this pull request as ready for review
September 7, 2026 23:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
request_json_objectused Flaskget_json(silent=True). Missing bodies and invalid JSON both returnedNone, which became{}. A POST of{not-jsonlooked like an empty object and could write.docgen-state.json. JSONnullwas also treated as a missing body.Change
Parse the raw request bytes with
json.loads. Empty / whitespace-only bodies stay{}. Invalid JSON raisesWizardError. JSONnullis rejected as a non-object (same as a list).Tests
/api/state→ 400, file not writtennull→ 400{}Out of scope
except Exceptionaroundnarration_topic_label