Fail closed when wizard path and git ref are not JSON strings - #133
Merged
Merged
Conversation
open-bundle path and tool/update ref used str(data.get(...) or default), so a boolean ref became True (a legal git ref) and a falsy 0/false silently installed main. Co-authored-by: jmjava <jmjava@gmail.com>
ruff, pytest (760 passed, 1 skipped), and docgen benchmark all green. Co-authored-by: jmjava <jmjava@gmail.com>
jmjava
marked this pull request as ready for review
September 7, 2026 23:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
POST /api/open-bundleandPOST /api/tool/updatestill usedstr(data.get(...) or default)after the wizard JSON-object / string-array work.path: ["/tmp/bundle"]became"['/tmp/bundle']"and looked like a missing yaml file.ref: truebecame"True", which matches the git-ref allowlist and wouldpip installfrom that ref.ref: 0/ref: falseare falsy, so they silently fell through tomain.Both fields now go through
require_json_string. Missing / nullpathstill means empty (path is required). Missing / null / emptyrefstill defaults tomain.Test plan
path→ 400; bool / number / listref→ 400; missingrefstill installsmainruff check src/ tests/pytest tests/— 760 passed, 1 skippeddocgen benchmark— meetssrc/docgen/benchmark_data/baseline.json(no--update-baseline)Milestone:
milestones/wizard-path-ref.md