Fail hostname Ollama URLs instead of warning - #26
Merged
Merged
Conversation
Hostname URLs such as https://my-ollama.evil.com only warned and still printed PASS, so a remote Ollama host could not redden the checker. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
classify_base_urlnow fails non-loopback hostnames such ashttps://my-ollama.evil.cominstead of warning and printingPASS deployment safety (warnings)with exit 0.classify_base_urlstay. Private LAN IPs still warn. Leftover Add Halo host profile, C4 diagrams, and public roadmap #5MAX_BYTESis untouched.Test plan
test_hostname_non_loopback_non_private_failstest_hostname_url_fails_run_checkstest_hostname_url_fails_deployment_safetytest_server_start_hostname_failstest_ci_deployment_safety_can_go_red/ leftover Refuse unsafe MCP payloads and attach local_review notes #10test_server_start_calls_classify_base_urlstill passMade with Cursor