Skip to content

fix(e2e): clone public apps without SSH secret - #50

Merged
jmjava merged 2 commits into
mainfrom
cursor/verify-intercept-least-rbac-fc5f
Sep 14, 2026
Merged

jmjava merged 2 commits into
mainfrom
cursor/verify-intercept-least-rbac-fc5f

Conversation

@jmjava

@jmjava jmjava commented Sep 14, 2026

Copy link
Copy Markdown
Owner

Summary

  • use authenticated SSH for application clones when a private key is present
  • fall back to HTTPS for public repositories when the Secret workspace is empty
  • create an empty clone credential Secret in E2E when no repository secret is configured
  • retain private-repository SSH support unchanged

Root cause

Both PR #49 matrices stopped before cluster setup because E2E_GIT_SSH_PRIVATE_KEY is not configured. The three stack-one application repositories used by this E2E are public, so requiring private credentials prevented valid public clone coverage.

Verification

  • confirmed all three E2E application repositories are public
  • Ruff and focused M17 tests: 13 passed
  • prescribed local regression: regression exit code: 0
  • fresh Telepresence/mirrord matrices are queued/running
Open in Web Open in Cursor 

cursoragent and others added 2 commits September 14, 2026 17:35
Co-authored-by: jmjava <jmjava@gmail.com>
Co-authored-by: jmjava <jmjava@gmail.com>
@jmjava
jmjava marked this pull request as ready for review September 14, 2026 17:41
@jmjava
jmjava merged commit 0cfd1e4 into main Sep 14, 2026
3 of 5 checks passed
jmjava added a commit that referenced this pull request Sep 14, 2026
* ci(e2e): automate intercept product paths (#37)

* ci(e2e): automate intercept product paths

Co-authored-by: jmjava <jmjava@gmail.com>

* fix(e2e): limit product flow help text

Co-authored-by: jmjava <jmjava@gmail.com>

* docs(m17): record intercept automation evidence

Co-authored-by: jmjava <jmjava@gmail.com>

* fix(e2e): prepare intercept namespace and results evidence

Co-authored-by: jmjava <jmjava@gmail.com>

---------

Co-authored-by: Cursor Agent <cursoragent@cursor.com>

* fix(ci): avoid matrix context in workflow concurrency (#38)

Co-authored-by: Cursor Agent <cursoragent@cursor.com>

* ci(results): schedule strict database regression (#39)

* ci(results): schedule strict database regression

Co-authored-by: jmjava <jmjava@gmail.com>

* docs(m17): record Results automation evidence

Co-authored-by: jmjava <jmjava@gmail.com>

---------

Co-authored-by: Cursor Agent <cursoragent@cursor.com>

* test(operator): complete domain CI assurance (#40)

* test(operator): add domain reconciliation integration

Co-authored-by: jmjava <jmjava@gmail.com>

* fix(operator): define integration list GVK

Co-authored-by: jmjava <jmjava@gmail.com>

* build(operator): upgrade golangci-lint for Go 1.23

Co-authored-by: jmjava <jmjava@gmail.com>

* chore(operator): resolve lint gate findings

Co-authored-by: jmjava <jmjava@gmail.com>

---------

Co-authored-by: Cursor Agent <cursoragent@cursor.com>

* fix(ci): allow lint toolchain bootstrap (#41)

Co-authored-by: Cursor Agent <cursoragent@cursor.com>

* fix(ci): retry Tekton controller apply races (#42)

* fix(ci): retry Tekton controller apply races

Co-authored-by: jmjava <jmjava@gmail.com>

* ci(operator): gate Tekton installer changes

Co-authored-by: jmjava <jmjava@gmail.com>

---------

Co-authored-by: Cursor Agent <cursoragent@cursor.com>

* fix(rbac): default pipeline bootstrap to least privilege (#43)

* fix(rbac): default pipeline bootstrap to least privilege

Co-authored-by: jmjava <jmjava@gmail.com>

* ci(rbac): require strict cluster regression

Co-authored-by: jmjava <jmjava@gmail.com>

---------

Co-authored-by: Cursor Agent <cursoragent@cursor.com>

* fix(test): isolate Helm RBAC rendering (#44)

Co-authored-by: Cursor Agent <cursoragent@cursor.com>

* fix(rbac): close strict cluster verification failures (#45)

* fix(test): isolate Helm RBAC rendering

Co-authored-by: jmjava <jmjava@gmail.com>

* fix(rbac): permit orchestrator PipelineRun creation

Co-authored-by: jmjava <jmjava@gmail.com>

---------

Co-authored-by: Cursor Agent <cursoragent@cursor.com>

* ci(rbac): isolate deterministic cluster gate (#46)

* ci(rbac): isolate deterministic cluster gate

Co-authored-by: jmjava <jmjava@gmail.com>

* ci(rbac): gate cluster workflow changes

Co-authored-by: jmjava <jmjava@gmail.com>

---------

Co-authored-by: Cursor Agent <cursoragent@cursor.com>

* fix(rbac): authorize StackRun submissions (#47)

Co-authored-by: Cursor Agent <cursoragent@cursor.com>

* fix(ci): probe StackRun RBAC after CRD install (#48)

Co-authored-by: Cursor Agent <cursoragent@cursor.com>

* ci(e2e): gate RBAC changes on intercept paths (#49)

Co-authored-by: Cursor Agent <cursoragent@cursor.com>

* fix(e2e): clone public apps without SSH secret (#50)

* ci(e2e): gate RBAC changes on intercept paths

Co-authored-by: jmjava <jmjava@gmail.com>

* fix(e2e): clone public apps without SSH secret

Co-authored-by: jmjava <jmjava@gmail.com>

---------

Co-authored-by: Cursor Agent <cursoragent@cursor.com>

* fix(tekton): resolve optional hooks deterministically

Co-authored-by: jmjava <jmjava@gmail.com>

* fix(tekton): allow compile tasks to bind cache PVC

Co-authored-by: jmjava <jmjava@gmail.com>

* fix(ci): wait for Tekton admission readiness

Co-authored-by: jmjava <jmjava@gmail.com>

---------

Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants