Skip to content

fix(tekton): resolve optional hooks deterministically - #51

Merged
jmjava merged 1 commit into
mainfrom
cursor/fix-intercept-hook-resolution-fc5f
Sep 14, 2026
Merged

jmjava merged 1 commit into
mainfrom
cursor/fix-intercept-hook-resolution-fc5f

Conversation

@jmjava

@jmjava jmjava commented Sep 14, 2026

Copy link
Copy Markdown
Owner

Summary

  • replace empty optional remote-hook names with an installed tekton-dag-hook-noop sentinel
  • keep hooks skipped unless a real hook Task name is configured
  • align the E2E clone Secret with the operator-generated PipelineRun workspace
  • fail product-path polling immediately when the underlying PipelineRun is terminally failed

Root cause

Both backends reached bootstrap, then Tekton rejected the Pipeline because cluster-resolver Task names were empty. Tekton resolves remote TaskRefs before evaluating when, producing CouldntGetTask: missing required cluster resolver params: name. The run then wasted 35 minutes because the StackRun exposed that Tekton reason instead of the small hard-coded terminal phase list.

Verification

  • shell syntax, Ruff, and YAML parsing: passed
  • focused hook/intercept tests: 7 passed
  • Helm lint: passed
  • prescribed local regression: regression exit code: 0
  • fresh Telepresence/mirrord matrices are running
Open in Web Open in Cursor 

Co-authored-by: jmjava <jmjava@gmail.com>
@jmjava
jmjava marked this pull request as ready for review September 14, 2026 19:12
@jmjava
jmjava merged commit d617235 into main Sep 14, 2026
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants