Conversation
Intercept E2E applies PR Task YAML but clones platform git-revision main, so sourcing scripts/run-stack-tests-runners.sh from the workspace failed both Telepresence and mirrord PR runs. Ship the script with the Task via ConfigMap from install-tekton and Helm. Co-authored-by: jmjava <jmjava@gmail.com>
RBAC helm-template tests run against a clean chart checkout, so the runner ConfigMap must be omitted until package.sh stages the script. Also collect compatibility pytest from each language package. Co-authored-by: jmjava <jmjava@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intercept E2E on #68 failed both Telepresence and mirrord because
run-stack-testssourcedscripts/run-stack-tests-runners.shfrom the cloned platform workspace. Product PRs still usegit-revision: main, which does not contain that file.This ships the runner script as ConfigMap
run-stack-tests-runnersfrominstall-tekton.shand Helm, and mounts it at/opt/tekton-dag.Follow-up on the first CI pass:
package.sh, so the ConfigMap is omitted until the script is stagedcheck-helm-chart.shstill requires the ConfigMapEvidence from run
35112503966:ERROR: run-stack-tests runners script missing: /workspace/test-source/scripts/run-stack-tests-runners.sh