Repository navigation
feat(jelly): settings declare their choices; release v0.0.2 - #7
Merged
Merged
Conversation
The access setting declares Jelly's three choices (Allowed, Ask before changes, Read only) with Jelly's own words, keeping all as the default. A vendored copy of Jelly's setting rules checks the declaration, and the jelly test checks that the options parser takes every declared value and refuses one outside them. docs/jelly.md describes the setting, which it said was absent.
Version 0.0.2 in package.json and the lockfile, the CHANGELOG's Unreleased section released as 0.0.2, and every install spec at #v0.0.2; the upgrade example removes #v0.0.1. Known limits say the access choices need a Jelly that reads them.
test/support/jelly-settings.ts is now the family's one copy of Jelly's PluginSettingSchema, settingValueIssue and the declaration's list rules, dependency-free, checked against Jelly's zod schema by a differential check, and pinned by hash in scripts/check-copies.mjs.
Owner
Author
|
Added one commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two commits.
feat(jelly): settings declare their choices— theaccesssetting declares Jelly's three choices (Allowed, Ask before changes, Read only) with Jelly's own words;allstays the default.test/support/jelly-settings.tsrestates Jelly's setting rules (PluginSettingSchema,settingValueIssue) without a schema library, and the jelly test checks the declaration against it, and that the options parser takes every declared value and refuses one outside them.docs/jelly.mddescribes the setting, which it said was absent.chore(release): prepare v0.0.2— version, lockfile, CHANGELOG released as 0.0.2 (2026-11-13), install specs at#v0.0.2, the upgrade example removing#v0.0.1, and a Known limits line.Needs a Jelly that includes app#1301: an older Jelly refuses a declaration with
choices.requiresnames declaration fields, not a Jelly version, so it is not set.npm run checkpasses locally.