chore(release): v0.13.3 — updater elevation fix (+ install scope) - #41
Merged
Merged
Conversation
Carries the fix for in-app updates of an all-users install run by a standard user (#40), which through 0.13.2 silently created a second per-user install instead of updating the one in Program Files. This is also the build that can finally exercise the elevated path: install it per-machine, then take the next update. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Elevation alone was not enough. Tauri's NSIS template sets MULTIUSER_INSTALLMODE_DEFAULT_REGISTRY_KEY/..._VALUENAME "CurrentUser", so MultiUser picks its scope from that value and reads HKCU before HKLM. On a machine this bug has already damaged — an all-users install plus the per-user copy an earlier update created — the per-user key wins and even an elevated installer updates the wrong one. Measured on this machine 2026-09-22 with a local e2e (test keypair, localhost endpoint, two signed NSIS builds): elevation alone moved HKCU 0.13.2 -> 0.13.4 and left HKLM at 0.13.3. With /allusers, the same setup moved HKLM 0.13.3 -> 0.13.4 and left the per-user decoy at 0.13.3. MULTIUSER_INSTALLMODE_COMMANDLINE is defined, so the switch overrides the registry default. It precedes /ARGS because everything after that is handed to the relaunched app. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two commits: the 0.13.3 version bump, and a follow-up fix that the pre-release e2e uncovered.
The bump — five declarations via
npm run version:bump 0.13.3;version:checkagrees. Branched off main after #40.90fdadd2— tell the elevated installer which scope to install into. #40 made the updater elevate when an all-users install is updated by a non-elevated process. Driving that end to end on a real machine showed elevation alone is not enough: Tauri's NSIS template setsMULTIUSER_INSTALLMODE_DEFAULT_REGISTRY_KEY/…_VALUENAME "CurrentUser", so MultiUser picks its scope from that value and reads HKCU before HKLM. On a machine the original bug has already damaged — an all-users install plus the per-user copy an earlier update created — the per-user key wins and even an elevated installer updates the wrong one.MULTIUSER_INSTALLMODE_COMMANDLINEis defined, so passing/allusersoverrides the default; it precedes/ARGSbecause everything after that is handed to the relaunched app.Pre-release e2e (local, no release needed)
Test minisign keypair, a config overlay pointing the endpoint at
http://127.0.0.1:8765, two signed NSIS builds (0.13.3 base, 0.13.4 update), a local server, and the base installed per-machine with admin credentials. Clicks dispatched as trustedInput.dispatchMouseEventover CDP./allusers)Program FilesexeEMBER\jeff_, not the admin ✓Round 2 was run with a per-user key deliberately planted, i.e. the exact condition that defeated round 1. Also verified along the way:
needsElevation: truereported byget_app_update_policy, the Settings hint rendering before the click, the launch check and download hitting the local server, and the MCP sidecar relaunching alongside the app. Both test builds were uninstalled afterwards; the machine is back to no LogTapper keys.cargo test --lib app_update13/13 (new: the scope switch must precede/ARGS)cargo clippy -- -D warningsclean90fdadd2in flightAfter merging
v0.13.3→release.ymlbuilds the draft.publish-packagespushes 0.13.3 to the tap and bucket; the winget job stays soft-failing until microsoft/winget-pkgs#438639 merges.🤖 Generated with Claude Code