docs: mark the winget install as pending Microsoft approval - #47
Merged
Merged
Conversation
README and every release body since v0.13.2 have printed 'winget install jpicklyk.LogTapper' as a working install, but the first manifest (microsoft/winget-pkgs#438639) is still in review, so the command finds nothing. Keep the command but say it is pending, link the PR, and point at Scoop or the direct download meanwhile. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
README.mdand the release-body template inrelease.ymlhave printedwinget install jpicklyk.LogTapperas a working install command since v0.13.2. The first manifest, microsoft/winget-pkgs#438639, is still awaiting review by the Microsoft maintainers, so right now the command finds no package.Both places now keep the command but say it's pending approval, link the winget-pkgs PR, and point to Scoop or the direct download in the meantime.
README.md: the Install section's winget block.github/workflows/release.yml: theRELEASE_BODYwinget line (affects future release notes)Not changed: the published notes for v0.13.2 and v0.13.3 still carry the unqualified line. Editing them changes public release pages, so that's left for you to decide.
Once #438639 merges: drop the "pending" wording from both places, and set
continue-on-errorto false on thewingetjob inpublish-packages.yml.Test plan
release.ymlstill parses (js-yaml); the renderedRELEASE_BODYfirst line reads as intendedjpicklyk.LogTapperhit is thewingetcreatecall inpublish-packages.yml)🤖 Generated with Claude Code