fix(packaging): point the nuspec's projectSourceUrl at the release tag - #53
Merged
Merged
Conversation
Chocolatey's automated review flagged projectSourceUrl and projectUrl as identical (both the repo root). Point projectSourceUrl at the source tree of the tagged release the package is built from, so it names the exact source for that version and no longer duplicates projectUrl. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
projectSourceUrlinpackaging/chocolatey/logtapper.nuspec.tmplnow points at the source tree of the tagged release, not the repo root:For 0.13.3 this renders as
.../tree/v0.13.3.projectUrlstays at the repo root.Why
Chocolatey's automated review flagged that
projectSourceUrlandprojectUrlwere identical. It asked us to make sureprojectSourceUrlpoints to source code, or to remove it. The note was advisory, not a required change. Linking to the release tag is the more accurate value anyway: it names the exact source each package version was built from, and it no longer duplicatesprojectUrl.Reviewer notes
vprefix matches the repo's tag scheme;releaseNotesin the same nuspec already usesreleases/tag/v{{VERSION}}.v0.13.3exists on origin.node scripts/render-packaging.mjs --checkrenders every template cleanly, andnpm run test:scriptspasses 5/5.verify-chocolatey.ymlruns on this PR because it touches the package.gh workflow run publish-packages.yml --ref main -f version=0.13.3(versions that aren't approved yet are pushed again on a re-run).🤖 Generated with Claude Code