fix: ensure listbox visibility before interacting with options in JWT.#939
Merged
Conversation
|
Preview URL https://next-jwt-m16z9g0r0-okta.vercel.app |
jonathanp-okta
marked this pull request as ready for review
July 20, 2026 16:26
jcmartinezdev
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By submitting a PR to this repository, you agree to the terms within the Auth0 Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.
Description
Fixes a race condition in the Playwright E2E test suites for the decoder and encoder "generate JWT example" tests, which caused 13 hard failures and 39 flaky tests on CI.
The
beforeEachhook clicked the algorithm picker to open the react-select dropdown but did not wait for the dropdown to finish rendering before the individual test attempted to click an option. Playwright would resolve the option element, then lose it as react-select re-rendered — producing consistentelement was detached from the DOMtimeouts even after 3 retries.The fix adds a
waitFor({ state: "visible" })on thelistboxrole after opening the picker, ensuring the dropdown is fully rendered before any option interaction. The option click is also scoped to within thelistboxcontainer for added stability.Scope is limited to
e2e/decoder.spec.tsande2e/encoder.spec.ts: no application logic, components, or library data are affected.References
N/A
Testing
This is a test stability fix with no application logic changes:
CI verification: the 13 previously hard-failing chromium decoder tests and 39 flaky encoder/decoder tests across chromium and firefox should now pass consistently without retries.
No new application behavior to verify manually.
This change adds test coverage for new/changed/fixed functionality
Checklist