reference-game: reject disjoint scramble with fewer than 2 stimuli - #91
Merged
Merged
Conversation
htsukamoto5
force-pushed
the
feat/reference-game-disjoint-n1-guard
branch
from
September 20, 2026 00:28
aeddb29 to
36f7aea
Compare
jodeleeuw
force-pushed
the
reference-game-cued-fidelity
branch
from
September 24, 2026 18:03
9aecd91 to
68f3d01
Compare
Reapplied onto the session-based multiplayer API (#94); the feature changes are unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
jodeleeuw
force-pushed
the
reference-game-cued-fidelity
branch
from
September 24, 2026 18:03
68f3d01 to
e4c9a0b
Compare
Reapplied onto the session-based multiplayer API (#94). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
jodeleeuw
force-pushed
the
feat/reference-game-disjoint-n1-guard
branch
from
September 24, 2026 18:04
36f7aea to
0a77370
Compare
jodeleeuw
changed the base branch from
reference-game-cued-fidelity
to
main
September 24, 2026 19:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacks on PR #80. A single object cannot differ in position between layouts, so disjoint mode with one stimulus silently yielded identical layouts, violating exactly the property the mode promises. This fails loudly at trial setup instead, documents the N >= 2 requirement on scramble_mode, and adds a wrapper test. Verification: reference-game suite 62/62, full repo 26 suites / 575 tests, build clean, diff-check clean.