Repository navigation
fix(sefariasqlite): resolve authors with an empty Hebrew name - #98
Merged
Merged
Conversation
Sefaria ships some authors with an empty `he` title (e.g. Nissim Chaim Moshe Mizrachi, author of Admat Kodesh), so the book got a blank author. 11 authors / 16 books are affected in the current export. Resolve the name from the `he` title, else a Hebrew override keyed by the Sefaria topic slug, else the English name; drop authors with no name. Fixes kdroidFilter/Zayit#444 Signed-off-by: Elie Gambache <elyahou.hadass@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes kdroidFilter/Zayit#444
Problem
Sefaria ships some authors with an empty
hetitle — Admat Kodesh's author is{"en": "Nissim Chaim Moshe Mizrachi", "he": "", ...}(same in their topics API). The reader stored the empty string, so the book had a blank author. In the current export, 11 authors / 16 books are affected (Sefer HaIkkarim, Shem MiShmuel, Rav Nissim Gaon, Be'er Sheva, Epistle of Rav Sherira Gaon, …).Fix
resolveSefariaAuthorNameresolves eachauthorsentry from:hetitle when non-blank,and drops the author when none is usable.
Tests
SefariaAuthorNamesTestcovers each branch.