Skip to content

fix(sefariasqlite): resolve authors with an empty Hebrew name - #98

Merged
kdroidFilter merged 1 commit into
masterfrom
fix/sefaria-empty-hebrew-author-444
Oct 8, 2026
Merged

kdroidFilter merged 1 commit into
masterfrom
fix/sefaria-empty-hebrew-author-444

Conversation

@kdroidFilter

Copy link
Copy Markdown
Owner

Fixes kdroidFilter/Zayit#444

Problem

Sefaria ships some authors with an empty he title — Admat Kodesh's author is {"en": "Nissim Chaim Moshe Mizrachi", "he": "", ...} (same in their topics API). The reader stored the empty string, so the book had a blank author. In the current export, 11 authors / 16 books are affected (Sefer HaIkkarim, Shem MiShmuel, Rav Nissim Gaon, Be'er Sheva, Epistle of Rav Sherira Gaon, …).

Fix

resolveSefariaAuthorName resolves each authors entry from:

  1. the he title when non-blank,
  2. a Hebrew override keyed by Sefaria topic slug (the 11 known cases),
  3. the English name,

and drops the author when none is usable.

Tests

SefariaAuthorNamesTest covers each branch.

Sefaria ships some authors with an empty `he` title (e.g. Nissim Chaim
Moshe Mizrachi, author of Admat Kodesh), so the book got a blank author.
11 authors / 16 books are affected in the current export.

Resolve the name from the `he` title, else a Hebrew override keyed by
the Sefaria topic slug, else the English name; drop authors with no name.

Fixes kdroidFilter/Zayit#444

Signed-off-by: Elie Gambache <elyahou.hadass@gmail.com>
@kdroidFilter
kdroidFilter merged commit 5f49769 into master Oct 8, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug in the book 'Admat Kodesh'

1 participant