fix(sefariasqlite): name the Maharsha in his Talmud commentaries' titles

generator/sefariasqlite/src/jvmMain/kotlin/io/github/kdroidfilter/seforimlibrary/sefariasqlite/SefariaBookTitles.kt

@@ -0,0 +1,20 @@
+package io.github.kdroidfilter.seforimlibrary.sefariasqlite
+
+/**
+ * Author prefixes for Sefaria collections whose Hebrew title doesn't name the author,
+ * keyed by English collective title. The app shows a commentary by its title without
+ * " על <base book>", so "חידושי אגדות" alone doesn't tell the reader it's the Maharsha.
+ */
+private val authorPrefixesByCollectiveTitle = mapOf(
+    "Chidushei Agadot" to "מהרש\"א",
+    "Chidushei Halachot" to "מהרש\"א",
+)
+
+/**
+ * Title displayed for a Sefaria book: its Hebrew title, prefixed with the author when
+ * its collection needs it. Only the display title changes; `heTitle` stays the natural key.
+ */
+internal fun sefariaDisplayTitle(heTitle: String, collectiveTitleEn: String?): String {
+    val prefix = collectiveTitleEn?.let { authorPrefixesByCollectiveTitle[it] } ?: return heTitle
+    return if (heTitle.startsWith(prefix)) heTitle else "$prefix - $heTitle"
+}

generator/sefariasqlite/src/jvmMain/kotlin/io/github/kdroidfilter/seforimlibrary/sefariasqlite/SefariaDirectImporter.kt

@@ -238,7 +238,7 @@ class SefariaDirectImporter(
                 id = bookId,
                 categoryId = catId,
                 sourceId = sourceId,
-                title = payload.heTitle,
+                title = sefariaDisplayTitle(payload.heTitle, payload.collectiveTitleEn),
                 heRef = payload.heTitle,
                 authors = resolvedAuthors,
                 pubPlaces = emptyList(),

generator/sefariasqlite/src/jvmTest/kotlin/io/github/kdroidfilter/seforimlibrary/sefariasqlite/SefariaBookTitlesTest.kt

@@ -0,0 +1,28 @@
+package io.github.kdroidfilter.seforimlibrary.sefariasqlite
+
+import kotlin.test.Test
+import kotlin.test.assertEquals
+
+/**
+ * Regression for https://github.com/kdroidFilter/Zayit/issues/440: the Maharsha's
+ * commentaries were listed as "חידושי הלכות" / "חידושי אגדות" without his name.
+ */
+class SefariaBookTitlesTest {
+    @Test
+    fun prefixesMaharshaCollections() {
+        assertEquals(
+            "מהרש\"א - חידושי אגדות על חולין",
+            sefariaDisplayTitle("חידושי אגדות על חולין", "Chidushei Agadot"),
+        )
+        assertEquals(
+            "מהרש\"א - חידושי הלכות על שבת",
+            sefariaDisplayTitle("חידושי הלכות על שבת", "Chidushei Halachot"),
+        )
+    }
+
+    @Test
+    fun keepsOtherTitles() {
+        assertEquals("רש\"י על ברכות", sefariaDisplayTitle("רש\"י על ברכות", "Rashi"))
+        assertEquals("ברכות", sefariaDisplayTitle("ברכות", null))
+    }
+}