fix: eliminate Go security findings and harden file handling#2
Draft
keller0 wants to merge 4 commits into
Draft
Conversation
Co-authored-by: keller0 <caijiaqi2017@gmail.com>
Co-authored-by: keller0 <caijiaqi2017@gmail.com>
Co-authored-by: keller0 <caijiaqi2017@gmail.com>
…tack Co-authored-by: keller0 <caijiaqi2017@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
1.25.12to pull in patched standard-library security fixescobra)ginstack and refactor HTTP server to standard librarynet/httpgin -> validator -> golang.org/x/cryptodependency chain that kept surfacing module-level security warningsWhy
Repository security checks initially showed reachable vulnerabilities and additional module warnings. After dependency upgrades there was still an unfixed module-level advisory tied to
golang.org/x/crypto/openpgpin transitive dependencies. Replacingginwith standard library handlers removes that dependency chain entirely and reduces attack surface.Changes
http.goginroutes withnet/httphandlers for/,/submit,/clearAll,/deleteFile,/upload, static routessanitizeFileNamevalidation for upload/delete file namessync.RWMutexto guard shared state (sData,imgList,fileList)go.modginand all related transitive web stack modulescobradirect dependencygo.sumValidation
go test ./...govulncheck ./...govulncheck -show verbose ./...All validation commands pass and
govulncheckreportsNo vulnerabilities found.