Skip to content

fix(init): generated workflows invoke the diff CLI correctly - #47

Merged
lostmartian merged 4 commits into
mainfrom
fix/init-workflow-diff-form
Sep 1, 2026
Merged

fix(init): generated workflows invoke the diff CLI correctly#47
lostmartian merged 4 commits into
mainfrom
fix/init-workflow-diff-form

Conversation

@lostmartian

Copy link
Copy Markdown
Collaborator

What

agentdiff init-generated workflows now call agentdiff diff <baseline> <candidate> --scenario <name> instead of the invalid agentdiff <candidate> --baseline <baseline> form. Adds a regression test.

Why

Found while rebuilding agentdiff-demo against 0.5.0-rc: with record/init/approve registered, the E1 diff-default patch prepends diff only when the first arg is not a command — the template form becomes diff <candidate> --baseline <baseline>, where --baseline is the baseline-store option, so the run dies with Missing argument 'candidate_path'. Every init-generated gate would fail in CI on first use.

How

  • Both template steps (gate + PR report) switched to the explicit two-positional diff form.
  • Regression test test_workflow_invokes_diff_with_valid_cli_form pins the exact invocation and bans --baseline from the generated workflow.

Testing

  • make lint → All checks passed
  • uv run python -m pytest → 430 passed (was 429)

Checklist

  • Exactly one logical change in this PR
  • make lint passes
  • uv run python -m pytest is green
  • Docs updated if user-facing
  • CHANGELOG.md entry added under [Unreleased] (if feat/fix)
  • Conventional title: type(scope): summary

Roadmap link: WS-E CLI / Phase 2 — 0.5.0 ship blocker found via agentdiff-demo PR #4.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Sep 1, 2026

Copy link
Copy Markdown

Deploying agentdiff with  Cloudflare Pages  Cloudflare Pages

Latest commit: 86743fc
Status: ✅  Deploy successful!
Preview URL: https://7b3fbee2.agentdiff.pages.dev
Branch Preview URL: https://fix-init-workflow-diff-form.agentdiff.pages.dev

View logs

@lostmartian
lostmartian merged commit c236a7b into main Sep 1, 2026
7 checks passed
@lostmartian
lostmartian deleted the fix/init-workflow-diff-form branch September 1, 2026 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant