fix(init): generated workflows invoke the diff CLI correctly - #47
Merged
Conversation
Deploying agentdiff with
|
| Latest commit: |
86743fc
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://7b3fbee2.agentdiff.pages.dev |
| Branch Preview URL: | https://fix-init-workflow-diff-form.agentdiff.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
agentdiff init-generated workflows now callagentdiff diff <baseline> <candidate> --scenario <name>instead of the invalidagentdiff <candidate> --baseline <baseline>form. Adds a regression test.Why
Found while rebuilding agentdiff-demo against 0.5.0-rc: with
record/init/approveregistered, the E1 diff-default patch prependsdiffonly when the first arg is not a command — the template form becomesdiff <candidate> --baseline <baseline>, where--baselineis the baseline-store option, so the run dies withMissing argument 'candidate_path'. Every init-generated gate would fail in CI on first use.How
diffform.test_workflow_invokes_diff_with_valid_cli_formpins the exact invocation and bans--baselinefrom the generated workflow.Testing
Checklist
make lintpassesuv run python -m pytestis greenCHANGELOG.mdentry added under[Unreleased](if feat/fix)type(scope): summaryRoadmap link: WS-E CLI / Phase 2 — 0.5.0 ship blocker found via agentdiff-demo PR #4.